qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v4 1/2] tpm: extend TPM emulator with state migr


From: Stefan Berger
Subject: Re: [Qemu-devel] [PATCH v4 1/2] tpm: extend TPM emulator with state migration support
Date: Mon, 5 Mar 2018 15:33:16 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0

On 03/02/2018 04:26 AM, Marc-André Lureau wrote:

+    return 0;
+}
+
+static const VMStateDescription vmstate_tpm_emulator = {
+    .name = "tpm-emulator",
+    .version_id = 1,
+    .minimum_version_id = 0,
version_id = 1 & minimum_version_id = 0 ?

It's the first version, let's have version_id = 0 (and you could
remove minimum_version).

It doesn't work... I cannot use version_id 0 in tpm_tis or in tpm_emulator. For tpm_tis I get the error 'Missing section footer' upon VM resume and for some weird reason it doesn't allocate the blob buffers when reading them in tpm_emulator. I get a NULL pointer instead. So, we are better off with version_id 1 here... The CRB seems to work as is.

   Stefan





reply via email to

[Prev in Thread] Current Thread [Next in Thread]