[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] misc: don't use hwaddr as a type in trace ev
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH v2] misc: don't use hwaddr as a type in trace events |
Date: |
Tue, 6 Mar 2018 13:47:06 +0000 |
On 6 March 2018 at 13:43, Daniel P. Berrangé <address@hidden> wrote:
> Use types that are defined by QEMU in trace events caused build failures
> for the UST trace backend:
>
> In file included from trace-ust-all.c:13:0:
> trace-ust-all.h:11844:206: error: unknown type name ‘hwaddr’
>
> It only knows about C built-in types, and any types that are pulled in
> from includs of qemu-common.h and lttng/tracepoint.h. This does not
> include the 'hwaddr' type, so replace it with a uint64_t which is what
> exec/hwaddr.h defines 'hwaddr' as. This fixes the build failure
> introduced by
>
> commit 9eb8040c2d2b38e1a40bb6129b1b668fa178fcab
> Author: Peter Maydell <address@hidden>
> Date: Fri Mar 2 10:45:39 2018 +0000
>
> hw/misc/tz-ppc: Model TrustZone peripheral protection controller
>
> Signed-off-by: Daniel P. Berrangé <address@hidden>
> ---
Reviewed-by: Peter Maydell <address@hidden>
I'll apply this to master, since it will fix the travis build.
thanks
-- PMM