[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 3/9] chardev: update net listener gcontext
From: |
Daniel P . Berrangé |
Subject: |
Re: [Qemu-devel] [PATCH v2 3/9] chardev: update net listener gcontext |
Date: |
Wed, 7 Mar 2018 12:26:49 +0000 |
User-agent: |
Mutt/1.9.2 (2017-12-15) |
On Tue, Mar 06, 2018 at 01:33:14PM +0800, Peter Xu wrote:
> TCP chardevs can be using QIO network listeners working in the
> background when in listening mode. However the network listeners are
> always running in main context. This can race with chardevs that are
> running in non-main contexts.
>
> To solve this, we need to re-setup the net listeners in
> tcp_chr_update_read_handler() with the newly cached gcontext.
>
> Reviewed-by: Marc-André Lureau <address@hidden>
> Signed-off-by: Peter Xu <address@hidden>
> ---
> chardev/char-socket.c | 26 ++++++++++++++++++++------
> 1 file changed, 20 insertions(+), 6 deletions(-)
Reviewed-by: Daniel P. Berrangé <address@hidden>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- [Qemu-devel] [PATCH v2 0/9] chardev: qio related non-default context support, Peter Xu, 2018/03/06
- [Qemu-devel] [PATCH v2 2/9] chardev: fix leak in tcp_chr_telnet_init_io(), Peter Xu, 2018/03/06
- [Qemu-devel] [PATCH v2 1/9] vl: export machine_init_done, Peter Xu, 2018/03/06
- [Qemu-devel] [PATCH v2 3/9] chardev: update net listener gcontext, Peter Xu, 2018/03/06
- Re: [Qemu-devel] [PATCH v2 3/9] chardev: update net listener gcontext,
Daniel P . Berrangé <=
- [Qemu-devel] [PATCH v2 4/9] chardev: allow telnet gsource to switch gcontext, Peter Xu, 2018/03/06
- [Qemu-devel] [PATCH v2 5/9] chardev: introduce chr_machine_done hook, Peter Xu, 2018/03/06
- [Qemu-devel] [PATCH v2 6/9] chardev: use chardev's gcontext for async connect, Peter Xu, 2018/03/06
- [Qemu-devel] [PATCH v2 7/9] chardev: tcp: postpone async connection setup, Peter Xu, 2018/03/06
- [Qemu-devel] [PATCH v2 8/9] chardev: tcp: let TLS run on chardev context, Peter Xu, 2018/03/06