qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 03/11] xen: defer call to xen_restrict until jus


From: Eduardo Habkost
Subject: Re: [Qemu-devel] [PATCH 03/11] xen: defer call to xen_restrict until just before os_setup_post
Date: Thu, 8 Mar 2018 17:03:45 -0300
User-agent: Mutt/1.9.2 (2017-12-15)

On Thu, Mar 08, 2018 at 05:39:09PM +0000, Ian Jackson wrote:
[...]
> diff --git a/vl.c b/vl.c
> index dae986b..e6e8e1e 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -4719,6 +4719,7 @@ int main(int argc, char **argv, char **envp)
>          vm_start();
>      }
>  
> +    xen_setup_post();

I don't think we should have accelerator-specific code in main(),
if we already have accelerator classes that can abstract that
out.  I suggest adding a AccelClass;:setup_post() method that can
be called here.

-- 
Eduardo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]