[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 03/11] xen: defer call to xen_restrict until jus
From: |
Eduardo Habkost |
Subject: |
Re: [Qemu-devel] [PATCH 03/11] xen: defer call to xen_restrict until just before os_setup_post |
Date: |
Thu, 8 Mar 2018 17:03:45 -0300 |
User-agent: |
Mutt/1.9.2 (2017-12-15) |
On Thu, Mar 08, 2018 at 05:39:09PM +0000, Ian Jackson wrote:
[...]
> diff --git a/vl.c b/vl.c
> index dae986b..e6e8e1e 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -4719,6 +4719,7 @@ int main(int argc, char **argv, char **envp)
> vm_start();
> }
>
> + xen_setup_post();
I don't think we should have accelerator-specific code in main(),
if we already have accelerator classes that can abstract that
out. I suggest adding a AccelClass;:setup_post() method that can
be called here.
--
Eduardo
- [Qemu-devel] [PATCH 05/11] xen: move xc_interface compatibility fallback further up the file, (continued)
- [Qemu-devel] [PATCH 05/11] xen: move xc_interface compatibility fallback further up the file, Ian Jackson, 2018/03/08
- [Qemu-devel] [PATCH 01/11] xen: link against xentoolcore, Ian Jackson, 2018/03/08
- [Qemu-devel] [PATCH 10/11] xen: Expect xenstore write to fail when restricted, Ian Jackson, 2018/03/08
- [Qemu-devel] [PATCH 04/11] xen: destroy_hvm_domain: Move reason into a variable, Ian Jackson, 2018/03/08
- [Qemu-devel] [PATCH 08/11] configure: do_compiler: Dump some extra info under bash, Ian Jackson, 2018/03/08
- [Qemu-devel] [PATCH 07/11] os-posix: Provide new -runas <uid>:<gid> facility, Ian Jackson, 2018/03/08
- [Qemu-devel] [PATCH 06/11] xen: destroy_hvm_domain: Try xendevicemodel_shutdown, Ian Jackson, 2018/03/08
- [Qemu-devel] [PATCH 11/11] scripts/get_maintainer.pl: Print proper error message for missing $file, Ian Jackson, 2018/03/08
- [Qemu-devel] [PATCH 02/11] xen: restrict: use xentoolcore_restrict_all, Ian Jackson, 2018/03/08
- [Qemu-devel] [PATCH 03/11] xen: defer call to xen_restrict until just before os_setup_post, Ian Jackson, 2018/03/08
- Re: [Qemu-devel] [PATCH 03/11] xen: defer call to xen_restrict until just before os_setup_post, Eduardo Habkost, 2018/03/09
Re: [Qemu-devel] [PATCH v6 00/11] xen: xen-domid-restrict improvements, no-reply, 2018/03/08
Re: [Qemu-devel] [PATCH v6 00/11] xen: xen-domid-restrict improvements, no-reply, 2018/03/08