[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 10/12] xen: Use newly added dmops for mapping VG
From: |
Anthony PERARD |
Subject: |
Re: [Qemu-devel] [PATCH 10/12] xen: Use newly added dmops for mapping VGA memory |
Date: |
Fri, 9 Mar 2018 15:44:31 +0000 |
User-agent: |
Mutt/1.9.4 (2018-02-28) |
On Thu, Mar 08, 2018 at 07:03:05PM +0000, Ian Jackson wrote:
> From: Ross Lagerwall <address@hidden>
>
> Xen unstable (to be in 4.11) has two new dmops, relocate_memory and
> pin_memory_cacheattr. Use these to set up the VGA memory, replacing the
> previous calls to libxc. This allows the VGA console to work properly
> when QEMU is running restricted (-xen-domid-restrict).
>
> Wrapper functions are provided to allow QEMU to work with older versions
> of Xen.
>
> Tweak the error handling while making this change:
> * Report pin_memory_cacheattr errors.
> * Report errors even when DEBUG_HVM is not set. This is useful for
> trying to understand why VGA is not working, since otherwise it just
> fails silently.
> * Fix the return values when an error occurs. The functions now
> consistently return -1 and set errno.
>
> CC: Ian Jackson <address@hidden>
> Signed-off-by: Ross Lagerwall <address@hidden>
> Reviewed-by: Ian Jackson <address@hidden>
> Signed-off-by: Ian Jackson <address@hidden>
> ---
> v6.1: Fix printf formats to match types in error_report messages
> Fix spurious \n in error_report messages
> Fix { } style issue
> v6: New patch in this version of the series
> ---
> configure | 19 +++++++++++++++++
> hw/i386/xen/xen-hvm.c | 50
> ++++++++++++++++++++++++---------------------
> include/hw/xen/xen_common.h | 32 +++++++++++++++++++++++++++++
> 3 files changed, 78 insertions(+), 23 deletions(-)
>
> diff --git a/hw/i386/xen/xen-hvm.c b/hw/i386/xen/xen-hvm.c
> index fb727bc..caa563b 100644
> --- a/hw/i386/xen/xen-hvm.c
> +++ b/hw/i386/xen/xen-hvm.c
> @@ -347,7 +347,7 @@ static int xen_add_to_physmap(XenIOState *state,
> MemoryRegion *mr,
> hwaddr offset_within_region)
> {
> - unsigned long i = 0;
> + unsigned long nr_pages;
> int rc = 0;
> XenPhysmap *physmap = NULL;
> hwaddr pfn, start_gpfn;
> @@ -396,22 +396,26 @@ go_physmap:
>
> pfn = phys_offset >> TARGET_PAGE_BITS;
> start_gpfn = start_addr >> TARGET_PAGE_BITS;
> - for (i = 0; i < size >> TARGET_PAGE_BITS; i++) {
> - unsigned long idx = pfn + i;
> - xen_pfn_t gpfn = start_gpfn + i;
> -
> - rc = xen_xc_domain_add_to_physmap(xen_xc, xen_domid,
> XENMAPSPACE_gmfn, idx, gpfn);
This patch seems to remove the last users of
xen_xc_domain_add_to_physmap(). Can it be remove from xen_common.h?
With that:
Acked-by: Anthony PERARD <address@hidden>
Thanks.
> - if (rc) {
> - DPRINTF("add_to_physmap MFN %"PRI_xen_pfn" to PFN %"
> - PRI_xen_pfn" failed: %d (errno: %d)\n", idx, gpfn, rc,
> errno);
> - return -rc;
> - }
> + nr_pages = size >> TARGET_PAGE_BITS;
> + rc = xendevicemodel_relocate_memory(xen_dmod, xen_domid, nr_pages, pfn,
> + start_gpfn);
> + if (rc) {
> + int saved_errno = errno;
> +
> + error_report("relocate_memory %lu pages from GFN %"HWADDR_PRIx
> + " to GFN %"HWADDR_PRIx" failed: %s",
> + nr_pages, pfn, start_gpfn, strerror(saved_errno));
> + errno = saved_errno;
> + return -1;
> }
>
--
Anthony PERARD
- Re: [Qemu-devel] [PATCH v6.1 00/11] xen: xen-domid-restrict improvements, Ian Jackson, 2018/03/08
- [Qemu-devel] [PATCH 04/12] xen: defer call to xen_restrict until just before os_setup_post, Ian Jackson, 2018/03/08
- [Qemu-devel] [PATCH 07/12] xen: destroy_hvm_domain: Try xendevicemodel_shutdown, Ian Jackson, 2018/03/08
- [Qemu-devel] [PATCH 09/12] configure: do_compiler: Dump some extra info under bash, Ian Jackson, 2018/03/08
- [Qemu-devel] [PATCH 02/12] xen: link against xentoolcore, Ian Jackson, 2018/03/08
- [Qemu-devel] [PATCH 05/12] xen: destroy_hvm_domain: Move reason into a variable, Ian Jackson, 2018/03/08
- [Qemu-devel] [PATCH 03/12] xen: restrict: use xentoolcore_restrict_all, Ian Jackson, 2018/03/08
- [Qemu-devel] [PATCH 06/12] xen: move xc_interface compatibility fallback further up the file, Ian Jackson, 2018/03/08
- [Qemu-devel] [PATCH 01/12] checkpatch: Add xendevicemodel_handle to the list of types, Ian Jackson, 2018/03/08