|
From: | Vladimir Sementsov-Ogievskiy |
Subject: | Re: [Qemu-devel] [PATCH 7/9] iotests.py: tiny refactor: move system imports up |
Date: | Fri, 9 Mar 2018 21:54:08 +0300 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 |
16.02.2018 23:44, Eric Blake wrote:
On 02/15/2018 07:51 AM, Vladimir Sementsov-Ogievskiy wrote:Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden> --- tests/qemu-iotests/iotests.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)What breaks if they aren't moved? But stylistically, this looks reasonable; and can be merged independently of NBD stuff if someone else wants.
This movement also make it a bit nearer to PEP8, as it dislike "E402 module level import not at top of file", because of "sys.path.append" before imports.. So, I'd just saved as many imports as I could)
Reviewed-by: Eric Blake <address@hidden>
-- Best regards, Vladimir
[Prev in Thread] | Current Thread | [Next in Thread] |