|
From: | Eric Blake |
Subject: | Re: [Qemu-devel] [PATCH v3 3/7] qapi: Replace qobject_to_X(o) by qobject_to(o, X) |
Date: | Sat, 10 Mar 2018 15:48:00 -0600 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 |
On 02/28/2018 12:08 PM, Max Reitz wrote:
+ options = qobject_to(options_obj, QDict);Bikeshedding - would it read any easier as: options = qobject_to(QDict, options_obj);
So at this point, I'm 70:30 in favor of doing the rename to have qobject_to(type, obj) for consistency with majority of other macros that take a type name (type names are already unusual as arguments to macros, whether or not the macro is named with ALL_CAPS). (Sorry, I know that means more busy work for you, if you agree with my reasoning)I agree, because it means I have a decision. :-)
Are you planning on posting a v4, or shall I go ahead and make the swap as part of staging this on my QAPI tree?
-- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
[Prev in Thread] | Current Thread | [Next in Thread] |