[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v12 24/28] sev/i386: add migration blocker
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH v12 24/28] sev/i386: add migration blocker |
Date: |
Tue, 13 Mar 2018 12:36:49 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 |
On 13/03/2018 12:28, Brijesh Singh wrote:
>
>
> On 3/13/18 4:33 AM, Paolo Bonzini wrote:
>> On 08/03/2018 13:48, Brijesh Singh wrote:
>>> sev_set_guest_state(SEV_STATE_RUNNING);
>>> +
>>> + /* add migration blocker */
>>> + error_setg(&sev_mig_blocker,
>>> + "SEV: Migration is not implemented");
>>> + ret = migrate_add_blocker(sev_mig_blocker, &local_err);
>>> + if (local_err) {
>>> + error_report_err(local_err);
>>> + error_free(sev_mig_blocker);
>>> + exit(1);
>>> + }
>>> }
>> I think this should be in sev_guest_init instead? Does migration
>> transfer the measurement, or is it lost forever? Not a blocker though.
>
> The launch measurement does not get transferred during the migration.
> During migration we get totally different measurement which is wrapped
> with transport key etc and that need to send to destination. IIRC, in my
> first attempt I was adding this blocker in sev_guest_init() but
> migration_add_blocker() was failing because sev_guest_init() is called
> before the migration_object_init().
I see, thanks. I'm not going to touch this part anyway. :)
We can fix it during the freeze period.
Paolo
- [Qemu-devel] [PATCH v12 20/28] hw/i386: set ram_debug_ops when memory encryption is enabled, (continued)
- [Qemu-devel] [PATCH v12 20/28] hw/i386: set ram_debug_ops when memory encryption is enabled, Brijesh Singh, 2018/03/08
- [Qemu-devel] [PATCH v12 16/28] sev/i386: add command to encrypt guest memory region, Brijesh Singh, 2018/03/08
- [Qemu-devel] [PATCH v12 19/28] sev/i386: finalize the SEV guest launch flow, Brijesh Singh, 2018/03/08
- [Qemu-devel] [PATCH v12 21/28] sev/i386: add debug encrypt and decrypt commands, Brijesh Singh, 2018/03/08
- [Qemu-devel] [PATCH v12 23/28] qmp: add query-sev-launch-measure command, Brijesh Singh, 2018/03/08
- [Qemu-devel] [PATCH v12 22/28] target/i386: clear C-bit when walking SEV guest page table, Brijesh Singh, 2018/03/08
- [Qemu-devel] [PATCH v12 24/28] sev/i386: add migration blocker, Brijesh Singh, 2018/03/08
- [Qemu-devel] [PATCH v12 25/28] cpu/i386: populate CPUID 0x8000_001F when SEV is active, Brijesh Singh, 2018/03/08
- [Qemu-devel] [PATCH v12 27/28] sev/i386: add sev_get_capabilities(), Brijesh Singh, 2018/03/08
- [Qemu-devel] [PATCH v12 26/28] qmp: add query-sev-capabilities command, Brijesh Singh, 2018/03/08
- [Qemu-devel] [PATCH v12 28/28] tests/qmp-test: blacklist sev specific qmp commands, Brijesh Singh, 2018/03/08