[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v11 00/13] Dirty bitmaps postcopy migration
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH v11 00/13] Dirty bitmaps postcopy migration |
|
Date: |
Tue, 13 Mar 2018 15:09:02 -0500 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 |
On 03/13/2018 03:01 PM, Vladimir Sementsov-Ogievskiy wrote:
It looks like a bug in a recent commit to checkpatch. It don't support do { }
while
Checking PATCH 11/13: migration: add postcopy migration of dirty bitmaps...
ERROR: braces {} are necessary for all arms of this statement
#737: FILE: migration/block-dirty-bitmap.c:690:
+ } while (!(s.flags & DIRTY_BITMAP_MIG_FLAG_EOS));
[...]
Indeed, this is a regression in Su Hang's commit 2b9aef6f.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org