Re: [Qemu-devel] [PATCH] dump-guest-memory: more descriptive lookup_type failure

[Laszlo Ersek]

On 03/14/18 15:24, address@hidden wrote:

> Checking PATCH 1/1: dump-guest-memory: more descriptive lookup_type failure...
> WARNING: line over 80 characters
> #34: FILE: scripts/dump-guest-memory.py:22:
> +    raise gdb.GdbError("Symbols must be loaded prior to sourcing 
> dump-guest-memory.\n"
> 
> ERROR: line over 90 characters
> #35: FILE: scripts/dump-guest-memory.py:23:
> +                       "Symbols may be loaded by first 'attach'ing a QEMU 
> process id or by 'load'ing a QEMU binary.")
> 
> total: 1 errors, 1 warnings, 12 lines checked

The current "width" of the script is currently:

$ wc -L scripts/dump-guest-memory.py
81 scripts/dump-guest-memory.py

I think it would be good to stick with 80 chars in this patch. (While
adhering to whatever Python idioms are considered necessary -- I think
Janosch and Marc-André can help with that.)

Once that's fixed, please add my:

Reviewed-by: Laszlo Ersek <address@hidden>

(And, I agree, this error message has been reported several times to me
as well.)

Thanks!
Laszlo