[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] docker: dump 'config.log' if ./configure fai
From: |
Fam Zheng |
Subject: |
Re: [Qemu-devel] [PATCH v2] docker: dump 'config.log' if ./configure fails |
Date: |
Fri, 16 Mar 2018 09:34:02 +0800 |
User-agent: |
Mutt/1.9.2 (2017-12-15) |
On Thu, 03/15 15:27, Philippe Mathieu-Daudé wrote:
> Suggested-by: Eric Blake <address@hidden>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> Reviewed-by: Daniel P. Berrangé <address@hidden>
> ---
> v2:
> - avoid subshell using { ; } (Eric)
> - use test_fail() instead of prep_fail() (Fam)
>
> tests/docker/common.rc | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/tests/docker/common.rc b/tests/docker/common.rc
> index 7951555e3f..046f8a5921 100755
> --- a/tests/docker/common.rc
> +++ b/tests/docker/common.rc
> @@ -30,7 +30,9 @@ build_qemu()
> $@"
> echo "Configure options:"
> echo $config_opts
> - $QEMU_SRC/configure $config_opts && make $MAKEFLAGS
> + $QEMU_SRC/configure $config_opts || \
> + { cat config.log && test_fail "Failed to run 'configure'"; }
> + make $MAKEFLAGS
> }
>
> test_fail()
> --
> 2.16.2
>
Queued, thanks!
Fam