[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] virtio_net: flush uncompleted TX on reset
From: |
Greg Kurz |
Subject: |
Re: [Qemu-devel] [PATCH v2] virtio_net: flush uncompleted TX on reset |
Date: |
Tue, 20 Mar 2018 11:20:08 +0100 |
On Tue, 20 Mar 2018 11:27:26 +0800
Jason Wang <address@hidden> wrote:
> >> -static
> >> void qemu_flush_or_purge_queued_packets(NetClientState *nc, bool
> >> purge)
> >> {
> >> nc->receive_disabled = 0;
> >>
> >>
> >
> > Applied and queued for -stable.
> >
> > Thanks
> >
>
> Unfortunately, this breaks hotplug test:
>
> TEST: tests/virtio-net-test... (pid=7117)
> /x86_64/virtio/net/pci/basic: OK
> /x86_64/virtio/net/pci/rx_stop_cont: OK
> /x86_64/virtio/net/pci/hotplug: Broken pipe
> FAIL
>
> Thanks
Hi Jason,
Yes, I've just realized this patch assumes the virtio-net device
does have an associated backend (ie, nc->peer != NULL) otherwise
we segfault. This happens to be the case with the hotplug test.
I'll send a v3.
Cheers,
--
Greg