[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 1/3] nvram: at24c: prevent segfault by checki
From: |
Wolfram Sang |
Subject: |
Re: [Qemu-devel] [PATCH v2 1/3] nvram: at24c: prevent segfault by checking "rom-size" |
Date: |
Tue, 20 Mar 2018 12:07:55 +0100 |
User-agent: |
NeoMutt/20170113 (1.7.2) |
> > + if (!ee->rsize) {
> > + ERR("rom-size not allowed to be 0\n");
>
> You can directly use error_report() in this patch.
My reasoning was that this patch is suitable for stable while the
error_report() stuff is not. I neither wanted to mix those two here nor
did I want to make the stable-patch depend on the non-stable patch. So,
I chose to use ERR here and fix all of ERR later. OK?
signature.asc
Description: PGP signature