[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v4 for 2.12 0/3] fix bitmaps migration through share
From: |
Vladimir Sementsov-Ogievskiy |
Subject: |
[Qemu-devel] [PATCH v4 for 2.12 0/3] fix bitmaps migration through shared storage |
Date: |
Tue, 20 Mar 2018 20:05:17 +0300 |
Hi all.
This fixes bitmaps migration through shared storage. Look at 02 for
details.
The bug introduced in 2.10 with the whole qcow2 bitmaps feature, so
qemu-stable in CC. However I doubt that someone really suffered from this.
Do we need dirty bitmaps at all in inactive case? - that was a question in v2.
And, keeping in mind that we are going to use inactive mode not only for
incoming migration, I'm not sure that answer is NO (but, it may be "NO" for
2.10, 2.11), so let's fix it in proposed here manner at least for 2.12.
v4:
01: r-b: Max
02: rewrite to do not load bitmaps if any bitmaps alredy exit, drop r-b
03: add missed change of 169.out
v3: tiny context changes in 01,02
03: instead of a separate test, enable corresponding case in existent one
v2:
John, thank you for reviewing v1.
changes:
add John's r-bs, change s/timeout=10/timeout=10.0/ in last patch
and drop old 03 patch, related to this timeout fix.
Vladimir Sementsov-Ogievskiy (3):
qcow2-bitmap: add qcow2_reopen_bitmaps_rw_hint()
qcow2: fix bitmaps loading when bitmaps already exist
iotests: enable shared migration cases in 169
block/qcow2.h | 2 ++
block/qcow2-bitmap.c | 15 ++++++++++++++-
block/qcow2.c | 17 ++++++++++++++++-
tests/qemu-iotests/169 | 8 +++-----
tests/qemu-iotests/169.out | 4 ++--
5 files changed, 37 insertions(+), 9 deletions(-)
--
2.11.1
- [Qemu-devel] [PATCH v4 for 2.12 0/3] fix bitmaps migration through shared storage,
Vladimir Sementsov-Ogievskiy <=
- [Qemu-devel] [PATCH v4 2/3] qcow2: handle reopening bitmaps on bdrv_invalidate_cache, Vladimir Sementsov-Ogievskiy, 2018/03/20
- [Qemu-devel] [PATCH v4 1/3] qcow2-bitmap: add qcow2_reopen_bitmaps_rw_hint(), Vladimir Sementsov-Ogievskiy, 2018/03/20
- [Qemu-devel] [PATCH v4 3/3] iotests: enable shared migration cases in 169, Vladimir Sementsov-Ogievskiy, 2018/03/20
- [Qemu-devel] [PATCH v4 2/3] qcow2: fix bitmaps loading when bitmaps already exist, Vladimir Sementsov-Ogievskiy, 2018/03/20
- Re: [Qemu-devel] [PATCH v4 for 2.12 0/3] fix bitmaps migration through shared storage, Max Reitz, 2018/03/21
- Re: [Qemu-devel] [PATCH v4 for 2.12 0/3] fix bitmaps migration through shared storage, Max Reitz, 2018/03/26