[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] raw iotest regressions in 2.12.0-rc0
From: |
Peter Xu |
Subject: |
Re: [Qemu-devel] raw iotest regressions in 2.12.0-rc0 |
Date: |
Thu, 22 Mar 2018 11:25:19 +0800 |
User-agent: |
Mutt/1.9.1 (2017-09-22) |
On Wed, Mar 21, 2018 at 05:58:48PM -0400, John Snow wrote:
> ./check -v -raw
> Failures: 109 132 136 148 152 183
>
> 3fd2457d18edf5736f713dfe1ada9c87a9badab1 is the first bad commit
> commit 3fd2457d18edf5736f713dfe1ada9c87a9badab1
> Author: Peter Xu <address@hidden>
> Date: Fri Mar 9 17:00:03 2018 +0800
>
> monitor: enable IO thread for (qmp & !mux) typed
>
> Start to use dedicate IO thread for QMP monitors that are not using
> MUXed chardev.
>
> Reviewed-by: Fam Zheng <address@hidden>
> Reviewed-by: Stefan Hajnoczi <address@hidden>
> Signed-off-by: Peter Xu <address@hidden>
> Message-Id: <address@hidden>
> Signed-off-by: Eric Blake <address@hidden>
>
>
> The symptom appears to be extra "RESUME" events in the stream that
> weren't expected by the original output for tests 109 and 183; the rest
> are python and I didn't dig yet.
>
> ./check -v raw
> Failures: 055
> Failed 5 of 5 tests
>
> 91ad45061af0fe44ac5dadb5bedaf4d7a08077c8 is the first bad commit
> commit 91ad45061af0fe44ac5dadb5bedaf4d7a08077c8
> Author: Peter Xu <address@hidden>
> Date: Fri Mar 9 17:00:05 2018 +0800
>
> tests: qmp-test: verify command batching
>
> OOB introduced DROP event for flow control. This should not affect old
> QMP clients. Add a command batching check to make sure of it.
>
> Reviewed-by: Stefan Hajnoczi <address@hidden>
> Signed-off-by: Peter Xu <address@hidden>
> Message-Id: <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>
> Signed-off-by: Eric Blake <address@hidden>
>
>
>
> Maybe these are known, but I wanted to consolidate them for rc0 for
> something easy to search for. There are others for qcow2 which I'll post
> in a bit...!
I'll have a look on this today and see whether this is the same
problem as reported by Max. Sorry for that, and thanks for reporting!
--
Peter Xu