Re: [Qemu-devel] [PATCH for-2.12 4/8] qapi: restrict allow-oob value to be "true"

[Marc-André Lureau]

On Mon, Mar 26, 2018 at 8:38 AM, Peter Xu <address@hidden> wrote:
> It was missed in the first version of OOB series.  We should check this
> to make sure we throw the right error when fault value is passed in.
>
> Signed-off-by: Peter Xu <address@hidden>

Not exactly required imho, but why not:
Reviewed-by: Marc-André Lureau <address@hidden>


> ---
>  scripts/qapi/common.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/qapi/common.py b/scripts/qapi/common.py
> index 2c05e3c284..3e14bc41f2 100644
> --- a/scripts/qapi/common.py
> +++ b/scripts/qapi/common.py
> @@ -872,7 +872,7 @@ def check_keys(expr_elem, meta, required, optional=[]):
>              raise QAPISemError(info,
>                                 "'%s' of %s '%s' should only use false value"
>                                 % (key, meta, name))
> -        if key == 'boxed' and value is not True:
> +        if (key == 'boxed' or key == 'allow-oob') and value is not True:
>              raise QAPISemError(info,
>                                 "'%s' of %s '%s' should only use true value"
>                                 % (key, meta, name))
> --
> 2.14.3
>