[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 4/9] hmp: disable monitor in preconfig state
From: |
Igor Mammedov |
Subject: |
Re: [Qemu-devel] [PATCH v4 4/9] hmp: disable monitor in preconfig state |
Date: |
Wed, 28 Mar 2018 13:16:53 +0200 |
On Fri, 23 Mar 2018 18:27:32 -0300
Eduardo Habkost <address@hidden> wrote:
> On Mon, Mar 12, 2018 at 02:11:10PM +0100, Igor Mammedov wrote:
> > Ban it for now, if someone would need it to work early,
> > one would have to implement checks if HMP command is valid
> > at preconfig state.
> >
> > Signed-off-by: Igor Mammedov <address@hidden>
> > ---
> > v4:
> > * v3 was only printing error but not preventing command execution,
> > Fix it by returning after printing error message.
> > ("Dr. David Alan Gilbert" <address@hidden>)
> > ---
> > monitor.c | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/monitor.c b/monitor.c
> > index a4417f2..ea0ca57 100644
> > --- a/monitor.c
> > +++ b/monitor.c
> > @@ -3104,6 +3104,11 @@ static void handle_hmp_command(Monitor *mon, const
> > char *cmdline)
> >
> > trace_handle_hmp_command(mon, cmdline);
> >
> > + if (runstate_check(RUN_STATE_PRECONFIG)) {
> > + monitor_printf(mon, "HMP not available in preconfig state\n");
> > + return;
>
> Not even the "cont" command? It would be useful for testing
> -preconfig.
As someone already said on the list it's very easy to test with
QMP nowdays, just use qmp-shell for that.
So if someone isn't willing to learn to use QMP, one can write
HMP part with proper white-listing.
I can extend error message like this:
"HMP not available in preconfig state, use QMP instead\n"
- [Qemu-devel] [PATCH v4 2/9] numa: split out NumaOptions parsing into parse_NumaOptions(), (continued)
[Qemu-devel] [PATCH v4 4/9] hmp: disable monitor in preconfig state, Igor Mammedov, 2018/03/12
[Qemu-devel] [PATCH v4 1/9] numa: postpone options post-processing till machine_run_board_init(), Igor Mammedov, 2018/03/12
[Qemu-devel] [PATCH v4 3/9] cli: add -preconfig option, Igor Mammedov, 2018/03/12