[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC 08/18] qemu.py: Close _qmp inside _post_shutdown()
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-devel] [RFC 08/18] qemu.py: Close _qmp inside _post_shutdown() |
Date: |
Wed, 4 Apr 2018 05:28:23 -0300 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 |
On 03/29/2018 06:38 PM, Eduardo Habkost wrote:
> This way all shutdown-related cleanup is kept in a single place.
>
> While at it, set _qmp to None after closing the socket, to avoid
> trying to reuse it by mistake later.
>
> Signed-off-by: Eduardo Habkost <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> scripts/qemu.py | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/scripts/qemu.py b/scripts/qemu.py
> index 4a71542c6b..1241e7f10b 100644
> --- a/scripts/qemu.py
> +++ b/scripts/qemu.py
> @@ -199,6 +199,10 @@ class QEMUMachine(object):
> self._qmp.accept()
>
> def _post_shutdown(self):
> + if self._qmp is not None:
> + self._qmp.close()
> + self._qmp = None
> +
> self._load_io_log()
> if self._qemu_log_file is not None:
> self._qemu_log_file.close()
> @@ -250,7 +254,6 @@ class QEMUMachine(object):
> def wait(self):
> '''Wait for the VM to power off'''
> self._popen.wait()
> - self._qmp.close()
> self._post_shutdown()
>
> def shutdown(self):
>
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [RFC 08/18] qemu.py: Close _qmp inside _post_shutdown(),
Philippe Mathieu-Daudé <=