[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] linux-user: call cpu_copy under clone_lock
From: |
Alex Bennée |
Subject: |
Re: [Qemu-devel] [PATCH] linux-user: call cpu_copy under clone_lock |
Date: |
Wed, 04 Apr 2018 13:52:09 +0100 |
User-agent: |
mu4e 1.1.0; emacs 26.0.91 |
Peter Maydell <address@hidden> writes:
> On 4 April 2018 at 11:27, Alex Bennée <address@hidden> wrote:
>> I'm wondering if it should be doing more. After all start/end_exclusive
>> rely on the cpu list and that isn't updated on thread creation - and
>> without that a bunch of other things fail like ld/st exclusive after
>> your first new thread is spawned.
>
> I think that is handled because creating a new thread calls
> cpu_copy(), which creates a new CPU object, which adds itself
> to the CPU list in its realize function (same as for system
> emulation new CPU objects).
Ahh that makes sense - I missed it hidden behind the realize.
--
Alex Bennée