Re: [Qemu-devel] [PATCHv5] dma/i82374: avoid double creation of i82374 device

[Philippe Mathieu-Daudé]

Hi Paolo,

On 04/05/2018 02:02 PM, Paolo Bonzini wrote:
> On 26/03/2018 17:05, Eduardo Otubo wrote:
>> QEMU fails when used with the following command line:
>>
>>     ./ppc64-softmmu/qemu-system-ppc64 -S -machine 40p,accel=tcg -device 
>> i82374
>>     qemu-system-ppc64: hw/isa/isa-bus.c:110: isa_bus_dma: Assertion 
>> `!bus->dma[0] && !bus->dma[1]' failed.
>>     Aborted (core dumped)
>>
>> The 40p machine type already creates the device i82374. If specified in
>> the command line, it will try to create it again, hence generating the
>> error. The function isa_bus_dma() isn't supposed to be called twice for
>> the same bus. This patch fixes this issue by propagating back the error
>> so QEMU can fail nicely without Abort or core dump.
>>
>> Signed-off-by: Eduardo Otubo <address@hidden>
> 
> Queued, thanks.

The fix is not this patch but:
http://lists.nongnu.org/archive/html/qemu-devel/2018-03/msg06678.html

with
http://lists.nongnu.org/archive/html/qemu-devel/2018-03/msg06844.html
Reviewed-by: Thomas Huth <address@hidden>
Tested-by: Thomas Huth <address@hidden>

and
http://lists.nongnu.org/archive/html/qemu-devel/2018-03/msg06827.html
Reviewed-by: Eduardo Otubo <address@hidden>

Regards,

Phil.