[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 1/1] linux-user: fix preadv/pwritev offsets
|
From: |
Max Filippov |
|
Subject: |
Re: [Qemu-devel] [PULL 1/1] linux-user: fix preadv/pwritev offsets |
|
Date: |
Mon, 9 Apr 2018 20:29:40 -0700 |
On Mon, Apr 9, 2018 at 8:20 PM, Richard Henderson
<address@hidden> wrote:
> On 04/10/2018 12:17 PM, Max Filippov wrote:
>> + uint64_t off = tlow |
>> + ((unsigned long long)thigh << TARGET_LONG_BITS / 2) <<
>
> There's a second instance of long long here; needs uint64_t.
Ehh, will fix.
BTW, why is uint64_t here better than unsigned long long? Just
shorter?
--
Thanks.
-- Max