[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 09/14] timer: rename ds1338 -> dsrtc
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH 09/14] timer: rename ds1338 -> dsrtc |
Date: |
Fri, 13 Apr 2018 13:49:54 +0100 |
On 24 March 2018 at 19:24, Michael Davidsaver <address@hidden> wrote:
> Prepare to generalize with a more generic
> name.
>
> Keep device name and vmstate name "ds1338"
> for compatibility.
>
> Signed-off-by: Michael Davidsaver <address@hidden>
> ---
> hw/timer/ds1338.c | 74
> +++++++++++++++++++++++++++----------------------------
> 1 file changed, 37 insertions(+), 37 deletions(-)
>
> diff --git a/hw/timer/ds1338.c b/hw/timer/ds1338.c
> index a969b5c8ba..28f788dd8e 100644
> --- a/hw/timer/ds1338.c
> +++ b/hw/timer/ds1338.c
> @@ -1,5 +1,5 @@
> /*
> - * MAXIM DS1338 I2C RTC+NVRAM
> + * MAXIM DSRTC I2C RTC+NVRAM
> *
I don't think the search-and-replace makes sense on this comment;
it should probably be "MAXIM DS13xx I2C RTC" or "DSxxxx" or
something, since we're trying to identify a product name/family.
Otherwise
Reviewed-by: Peter Maydell <address@hidden>
thanks
-- PMM
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH 09/14] timer: rename ds1338 -> dsrtc,
Peter Maydell <=