[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH qemu] RFC: memory/hmp: Print owners/parents in "
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH qemu] RFC: memory/hmp: Print owners/parents in "info mtree" |
Date: |
Wed, 18 Apr 2018 11:23:09 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 |
On 18/04/2018 08:32, Markus Armbruster wrote:
> Paolo Bonzini <address@hidden> writes:
>
>> On 17/04/2018 14:18, Igor Mammedov wrote:
>>>> What's the point of an object name if it cannot be unique?
>>> It should be sufficient for it to be unique within parent's
>>> scope and object_property_add_child() should make sure that
>>> added object is unique within its parent's namespace.
>>> Having named object from starters is useful as object
>>> won't have to piggyback on parent (object_get_canonical_path_component)
>>> when it need its own name. Then named object could use its name
>>> freely anywhere including initfn, property setters/getters and
>>> let object_property_add_child() take care of possible name
>>> conflict.
>>
>> I agree that it looks nice, but I'm worried that people forget that the
>> path component is only unique until object_unparent(). The use for
>> DEVICE_DELETED events is already a bad thing...
>
> Hmm. If the canonical QOM path isn't the proper way to identify a
> device in QMP, what else is? Honest question!
The canonical path is; the last component alone is not.
Paolo
- Re: [Qemu-devel] [PATCH qemu] RFC: memory/hmp: Print owners/parents in "info mtree", Dr. David Alan Gilbert, 2018/04/11
- Re: [Qemu-devel] [PATCH qemu] RFC: memory/hmp: Print owners/parents in "info mtree", Paolo Bonzini, 2018/04/12
- Re: [Qemu-devel] [PATCH qemu] RFC: memory/hmp: Print owners/parents in "info mtree", Igor Mammedov, 2018/04/16
- Re: [Qemu-devel] [PATCH qemu] RFC: memory/hmp: Print owners/parents in "info mtree", Paolo Bonzini, 2018/04/16
- Re: [Qemu-devel] [PATCH qemu] RFC: memory/hmp: Print owners/parents in "info mtree", Igor Mammedov, 2018/04/16
- Re: [Qemu-devel] [PATCH qemu] RFC: memory/hmp: Print owners/parents in "info mtree", Paolo Bonzini, 2018/04/16
- Re: [Qemu-devel] [PATCH qemu] RFC: memory/hmp: Print owners/parents in "info mtree", Igor Mammedov, 2018/04/17
- Re: [Qemu-devel] [PATCH qemu] RFC: memory/hmp: Print owners/parents in "info mtree", Paolo Bonzini, 2018/04/17
- Re: [Qemu-devel] [PATCH qemu] RFC: memory/hmp: Print owners/parents in "info mtree", Markus Armbruster, 2018/04/18
- Re: [Qemu-devel] [PATCH qemu] RFC: memory/hmp: Print owners/parents in "info mtree",
Paolo Bonzini <=
Re: [Qemu-devel] [PATCH qemu] RFC: memory/hmp: Print owners/parents in "info mtree", Alexey Kardashevskiy, 2018/04/18