[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] mux: fix ctrl-a b again
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH] mux: fix ctrl-a b again |
Date: |
Wed, 18 Apr 2018 12:55:16 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 |
On 18/04/2018 12:36, Marc-André Lureau wrote:
>
> + if (chr == NULL || chr->be) {
> + name = g_strdup_printf("discarding-serial%d", i);
> + chr = qemu_chr_new(name, "null");
> + } else {
> + name = g_strdup_printf("serial%d", i);
> + }
>
> Why do you check if chr->be ? In case of a mux chardev, it may already
> have an active frontend (yeah be is CharBackend which is the frontend,
> I still can't grasp that either, please Paolo change your mind! ;).
CharBackend is not the frontend, it is *used* by the front-end. It is
the qemu_chr_* functions that are named wrong (they're named according
to the user rather than the recipient).
Paolo
- [Qemu-devel] [PATCH] mux: fix ctrl-a b again, Marc-André Lureau, 2018/04/16
- Re: [Qemu-devel] [PATCH] mux: fix ctrl-a b again, Peter Maydell, 2018/04/16
- Re: [Qemu-devel] [PATCH] mux: fix ctrl-a b again, Daniel P . Berrangé, 2018/04/16
- Re: [Qemu-devel] [PATCH] mux: fix ctrl-a b again, Peter Maydell, 2018/04/17
- Re: [Qemu-devel] [PATCH] mux: fix ctrl-a b again, Philippe Mathieu-Daudé, 2018/04/17
- Re: [Qemu-devel] [PATCH] mux: fix ctrl-a b again, Peter Maydell, 2018/04/17
- Re: [Qemu-devel] [PATCH] mux: fix ctrl-a b again, Peter Maydell, 2018/04/17
- Re: [Qemu-devel] [PATCH] mux: fix ctrl-a b again, Marc-André Lureau, 2018/04/17
- Re: [Qemu-devel] [PATCH] mux: fix ctrl-a b again, Marc-André Lureau, 2018/04/18
- Re: [Qemu-devel] [PATCH] mux: fix ctrl-a b again,
Paolo Bonzini <=
- Re: [Qemu-devel] [PATCH] mux: fix ctrl-a b again, Marc-André Lureau, 2018/04/18
- Re: [Qemu-devel] [PATCH] mux: fix ctrl-a b again, Paolo Bonzini, 2018/04/18
- Re: [Qemu-devel] [PATCH] mux: fix ctrl-a b again, Marc-André Lureau, 2018/04/18
- Re: [Qemu-devel] [PATCH] mux: fix ctrl-a b again, Paolo Bonzini, 2018/04/18
- Re: [Qemu-devel] [PATCH] mux: fix ctrl-a b again, Marc-André Lureau, 2018/04/18
- Re: [Qemu-devel] [PATCH] mux: fix ctrl-a b again, Peter Maydell, 2018/04/18
- Re: [Qemu-devel] [PATCH] mux: fix ctrl-a b again, Paolo Bonzini, 2018/04/18
- Re: [Qemu-devel] [PATCH] mux: fix ctrl-a b again, Philippe Mathieu-Daudé, 2018/04/18
- Re: [Qemu-devel] [PATCH] mux: fix ctrl-a b again, Philippe Mathieu-Daudé, 2018/04/18