[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] configure: add sanity check to catch builds
From: |
Cornelia Huck |
Subject: |
Re: [Qemu-devel] [PATCH v2] configure: add sanity check to catch builds from "git archive" |
Date: |
Wed, 18 Apr 2018 19:54:12 +0200 |
On Wed, 18 Apr 2018 18:11:51 +0100
Daniel P. Berrangé <address@hidden> wrote:
> The "git archive" feature creates tarballs which are missing all
> submodule content. GitHub unhelpfully provides users with "Download"
> links that claim to give them valid source release tarballs. These
> GitHub archives will not be buildable as they are created by the
> "git archive" feature and so are missing content. The user gets
> unhelpful messages from make such as:
>
> fatal error: ui/input-keymap-atset1-to-qcode.c: No such file or directory
>
> By adding a sanity check we can give users an informative message about
> what they've done wrong.
>
> Signed-off-by: Daniel P. Berrangé <address@hidden>
> ---
> configure | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>
> diff --git a/configure b/configure
> index 0a19b033bc..089b00068c 100755
> --- a/configure
> +++ b/configure
> @@ -296,6 +296,24 @@ then
> else
> git_update=no
> git_submodules=""
> +
> + if ! test -f "$source_path/ui/keycodemapdb/README"
> + then
> + echo
> + echo "ERROR: missing file $source_path/ui/keycodemapdb/README"
> + echo
> + echo "This is not a GIT checkout but module content appears to"
> + echo "be missing. Do not use 'git archive' or GitHub download links"
> + echo "to acquire QEMU source archives. Non-GIT builds are only"
> + echo "supported with source archives linked from:"
> + echo
> + echo " https://www.qemu.org/download/"
> + echo
> + echo "Developers working with GIT can use scripts/archive-source.sh"
> + echo "if they need to create valid source archives."
> + echo
> + exit 1
> + fi
> fi
> git="git"
>
Reviewed-by: Cornelia Huck <address@hidden>