[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 4/4] ui: document non-qapi parser cases.
From: |
Gerd Hoffmann |
Subject: |
[Qemu-devel] [PATCH 4/4] ui: document non-qapi parser cases. |
Date: |
Thu, 19 Apr 2018 15:20:26 +0200 |
Add comments to the cases not (yet) switched
over to parse_display_qapi().
Signed-off-by: Gerd Hoffmann <address@hidden>
---
vl.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/vl.c b/vl.c
index 1123cd792e..d35c443b8c 100644
--- a/vl.c
+++ b/vl.c
@@ -2121,6 +2121,16 @@ static void parse_display(const char *p)
const char *opts;
if (strstart(p, "sdl", &opts)) {
+ /*
+ * sdl DisplayType needs hand-crafted parser instead of
+ * parse_display_qapi() due to some options not in
+ * DisplayOptions, specifically:
+ * - frame
+ * Already deprecated.
+ * - ctrl_grab + alt_grab
+ * Not clear yet what happens to them long-term. Should
+ * replaced by something better or deprecated and dropped.
+ */
dpy.type = DISPLAY_TYPE_SDL;
while (*opts) {
const char *nextopt;
@@ -2182,6 +2192,10 @@ static void parse_display(const char *p)
opts = nextopt;
}
} else if (strstart(p, "vnc", &opts)) {
+ /*
+ * vnc isn't a (local) DisplayType but a protocol for remote
+ * display access.
+ */
if (*opts == '=') {
vnc_parse(opts + 1, &error_fatal);
} else {
--
2.9.3