[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 4/5] qobject: modify qobject_ref() to return
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v6 4/5] qobject: modify qobject_ref() to return obj |
Date: |
Thu, 19 Apr 2018 10:32:41 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 |
On 04/19/2018 10:01 AM, Marc-André Lureau wrote:
> For convenience and clarity, make it possible to call qobject_ref() at
> the time when the reference is associated with a variable, or
> argument, by making qobject_ref() return the same pointer as given.
>
> Signed-off-by: Marc-André Lureau <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>
You've made some substantial changes to the macro, I would have dropped
R-b to ensure those changes get reviewed. In particular,
> ---
> +++ b/include/qapi/qmp/qobject.h
> @@ -72,11 +72,12 @@ static inline void qobject_init(QObject *obj, QType type)
> obj->base.type = type;
> }
>
> -static inline void qobject_ref_impl(QObject *obj)
> +static inline void *qobject_ref_impl(QObject *obj)
> {
> if (obj) {
> obj->base.refcnt++;
> }
> + return obj;
This hunk is now useless,
> @@ -103,8 +104,15 @@ static inline void qobject_unref_impl(QObject *obj)
>
> /**
> * qobject_ref(): Increment QObject's reference count
> + *
> + * Returns: the same @obj. The type of @obj will be propagated to the
> + * return type.
> */
> -#define qobject_ref(obj) qobject_ref_impl(QOBJECT(obj))
> +#define qobject_ref(obj) ({ \
> + typeof(obj) _o = (obj); \
> + qobject_ref_impl(QOBJECT(_o)); \
> + _o; \
since nothing ever uses the return value.
But that said, I'm still okay with R-b with or without the useless hunk.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
Re: [Qemu-devel] [PATCH v6 1/5] qobject: ensure base is at offset 0, Markus Armbruster, 2018/04/27
[Qemu-devel] [PATCH v6 2/5] qobject: use a QObjectBase_ struct, Marc-André Lureau, 2018/04/19
[Qemu-devel] [PATCH v6 5/5] qobject: modify qobject_ref() to assert on NULL, Marc-André Lureau, 2018/04/19
[Qemu-devel] [PATCH v6 4/5] qobject: modify qobject_ref() to return obj, Marc-André Lureau, 2018/04/19
[Qemu-devel] [PATCH v6 3/5] qobject: replace qobject_incref/QINCREF qobject_decref/QDECREF, Marc-André Lureau, 2018/04/19
Re: [Qemu-devel] [PATCH v6 0/5] Simplify qobject refcount, Eric Blake, 2018/04/19