[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 09/43] docker: extend "cc" command to accept
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-devel] [PATCH v2 09/43] docker: extend "cc" command to accept compiler |
Date: |
Thu, 19 Apr 2018 23:43:50 -0300 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 |
On 04/19/2018 10:58 AM, Alex Bennée wrote:
> When calling our cross-compilation images we want to call something
> other than the default cc.
>
> Signed-off-by: Alex Bennée <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
>
> ---
> v2
> - use arg.cc default to simplify logic
> ---
> tests/docker/docker.py | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/tests/docker/docker.py b/tests/docker/docker.py
> index bcc3ee2dee..59bce9f19a 100755
> --- a/tests/docker/docker.py
> +++ b/tests/docker/docker.py
> @@ -415,6 +415,8 @@ class CcCommand(SubCommand):
> def args(self, parser):
> parser.add_argument("--image", "-i", required=True,
> help="The docker image in which to run cc")
> + parser.add_argument("--cc", default="cc",
> + help="The compiler executable to call")
> parser.add_argument("--source-path", "-s", nargs="*", dest="paths",
> help="""Extra paths to (ro) mount into container
> for
> reading sources""")
> @@ -428,7 +430,7 @@ class CcCommand(SubCommand):
> if args.paths:
> for p in args.paths:
> cmd += ["-v", "%s:%s:ro,z" % (p, p)]
> - cmd += [args.image, "cc"]
> + cmd += [args.image, args.cc]
> cmd += argv
> return Docker().command("run", cmd, args.quiet)
>
>
- Re: [Qemu-devel] [PATCH v2 06/43] configure: set cross_cc_FOO for host compiler, (continued)
- [Qemu-devel] [PATCH v2 01/43] docker: add "probe" command for configure, Alex Bennée, 2018/04/19
- [Qemu-devel] [PATCH v2 05/43] configure: allow user to specify --cross-cc-cflags-foo=, Alex Bennée, 2018/04/19
- [Qemu-devel] [PATCH v2 10/43] docker: allow "cc" command to run in user context, Alex Bennée, 2018/04/19
- [Qemu-devel] [PATCH v2 14/43] tests/tcg/multiarch: enable additional linux-test tests, Alex Bennée, 2018/04/19
- [Qemu-devel] [PATCH v2 08/43] docker: Add "cc" subcommand, Alex Bennée, 2018/04/19
- [Qemu-devel] [PATCH v2 09/43] docker: extend "cc" command to accept compiler, Alex Bennée, 2018/04/19
- [Qemu-devel] [PATCH v2 07/43] Makefile: Rename TARGET_DIRS to TARGET_LIST, Alex Bennée, 2018/04/19
- [Qemu-devel] [PATCH v2 18/43] tests/tcg/i386: Build fix for hello-i386, Alex Bennée, 2018/04/19
- [Qemu-devel] [PATCH v2 17/43] tests/tcg: enable building for i386, Alex Bennée, 2018/04/19
- [Qemu-devel] [PATCH v2 13/43] tests/tcg/multiarch: Build fix for linux-test, Alex Bennée, 2018/04/19
- [Qemu-devel] [PATCH v2 35/43] tests/tcg/Makefile: update to be called from Makefile.target, Alex Bennée, 2018/04/19
- [Qemu-devel] [PATCH v2 22/43] tests/tcg/x86_64: add Makefile.target, Alex Bennée, 2018/04/19
- [Qemu-devel] [PATCH v2 16/43] docker: Add fedora-i386-cross image, Alex Bennée, 2018/04/19