Re: [Qemu-devel] [Qemu-block] [PATCH 08/19] block: Remove bdrv_drain_recurse()

[Stefan Hajnoczi]

On Wed, Apr 11, 2018 at 06:39:29PM +0200, Kevin Wolf wrote:
> For bdrv_drain(), recursively waiting for child node requests is
> pointless because we didn't quiesce their parents, so new requests could
> come in anyway. Letting the function work only on a single node makes it
> more consistent.
> 
> For subtree drains and drain_all, we already have the recursion in
> bdrv_do_drained_begin(), so the extra recursion doesn't add anything
> either.
> 
> Remove the useless code.
> 
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
>  block/io.c | 36 +++---------------------------------
>  1 file changed, 3 insertions(+), 33 deletions(-)

Reviewed-by: Stefan Hajnoczi <address@hidden>

signature.asc
Description: PGP signature