[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 11/13] block/mirror: Add active mirroring
From: |
Max Reitz |
Subject: |
Re: [Qemu-devel] [PATCH v4 11/13] block/mirror: Add active mirroring |
Date: |
Fri, 20 Apr 2018 15:24:19 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 |
On 2018-04-12 00:14, Eric Blake wrote:
> On 04/11/2018 01:54 PM, Max Reitz wrote:
>> This patch implements active synchronous mirroring. In active mode, the
>> passive mechanism will still be in place and is used to copy all
>> initially dirty clusters off the source disk; but every write request
>> will write data both to the source and the target disk, so the source
>> cannot be dirtied faster than data is mirrored to the target. Also,
>> once the block job has converged (BLOCK_JOB_READY sent), source and
>> target are guaranteed to stay in sync (unless an error occurs).
>>
>> Active mode is completely optional and currently disabled at runtime. A
>> later patch will add a way for users to enable it.
>>
>> Signed-off-by: Max Reitz <address@hidden>
>> Reviewed-by: Fam Zheng <address@hidden>
>> ---
>> qapi/block-core.json | 18 ++++
>> block/mirror.c | 252
>> ++++++++++++++++++++++++++++++++++++++++++++++++++-
>> 2 files changed, 265 insertions(+), 5 deletions(-)
>>
>> diff --git a/qapi/block-core.json b/qapi/block-core.json
>> index c50517bff3..8210d601f4 100644
>> --- a/qapi/block-core.json
>> +++ b/qapi/block-core.json
>> @@ -1049,6 +1049,24 @@
>> { 'enum': 'MirrorSyncMode',
>> 'data': ['top', 'full', 'none', 'incremental'] }
>>
>> +##
>> +# @MirrorCopyMode:
>> +#
>> +# An enumeration whose values tell the mirror block job when to
>> +# trigger writes to the target.
>> +#
>> +# @background: copy data in background only.
>> +#
>> +# @write-blocking: when data is written to the source, write it
>> +# (synchronously) to the target as well. In
>> +# addition, data is copied in background just like in
>> +# @background mode.
>> +#
>> +# Since: 2.12
>
> Missed an instance of 2.13
:-/
Will fix.
Max
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [Qemu-block] [PATCH v4 06/13] block: Generalize should_update_child() rule, (continued)
- [Qemu-devel] [PATCH v4 07/13] hbitmap: Add @advance param to hbitmap_iter_next(), Max Reitz, 2018/04/11
- [Qemu-devel] [PATCH v4 08/13] test-hbitmap: Add non-advancing iter_next tests, Max Reitz, 2018/04/11
- [Qemu-devel] [PATCH v4 09/13] block/dirty-bitmap: Add bdrv_dirty_iter_next_area, Max Reitz, 2018/04/11
- [Qemu-devel] [PATCH v4 10/13] block/mirror: Add MirrorBDSOpaque, Max Reitz, 2018/04/11
- [Qemu-devel] [PATCH v4 12/13] block/mirror: Add copy mode QAPI interface, Max Reitz, 2018/04/11
- [Qemu-devel] [PATCH v4 11/13] block/mirror: Add active mirroring, Max Reitz, 2018/04/11
- [Qemu-devel] [PATCH v4 13/13] iotests: Add test for active mirroring, Max Reitz, 2018/04/11