[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 03/13] hw/mips/boston.c: Don't create "null" cha
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-devel] [PATCH 03/13] hw/mips/boston.c: Don't create "null" chardevs for serial devices |
Date: |
Fri, 20 Apr 2018 23:50:05 -0300 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 |
On 04/20/2018 11:52 AM, Peter Maydell wrote:
> Following commit 12051d82f004024, UART devices should handle
> being passed a NULL pointer chardev, so we don't need to
> create "null" backends in board code. Remove the code that
> does this and updates serial_hds[].
>
> Signed-off-by: Peter Maydell <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Tested-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> hw/mips/boston.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/hw/mips/boston.c b/hw/mips/boston.c
> index fb23161b33..14f0f6673b 100644
> --- a/hw/mips/boston.c
> +++ b/hw/mips/boston.c
> @@ -505,10 +505,6 @@ static void boston_mach_init(MachineState *machine)
> "boston-platregs", 0x1000);
> memory_region_add_subregion_overlap(sys_mem, 0x17ffd000, platreg, 0);
>
> - if (!serial_hds[0]) {
> - serial_hds[0] = qemu_chr_new("serial0", "null");
> - }
> -
> s->uart = serial_mm_init(sys_mem, 0x17ffe000, 2,
> get_cps_irq(s->cps, 3), 10000000,
> serial_hds[0], DEVICE_NATIVE_ENDIAN);
>
- [Qemu-devel] [PATCH 05/13] hw/xtensa/xtfpga.c: Don't create "null" chardevs for serial devices, (continued)
- [Qemu-devel] [PATCH 05/13] hw/xtensa/xtfpga.c: Don't create "null" chardevs for serial devices, Peter Maydell, 2018/04/20
- [Qemu-devel] [PATCH 04/13] hw/mips/mips_malta: Don't create "null" chardevs for serial devices, Peter Maydell, 2018/04/20
- [Qemu-devel] [PATCH 08/13] Remove checks on MAX_SERIAL_PORTS that are just bounds checks, Peter Maydell, 2018/04/20
- [Qemu-devel] [PATCH 03/13] hw/mips/boston.c: Don't create "null" chardevs for serial devices, Peter Maydell, 2018/04/20
- [Qemu-devel] [PATCH 02/13] hw/arm/fsl-imx*: Don't create "null" chardevs for serial devices, Peter Maydell, 2018/04/20
- [Qemu-devel] [PATCH 01/13] hw/char/serial: Allow disconnected chardevs, Peter Maydell, 2018/04/20
- [Qemu-devel] [PATCH 07/13] Change references to serial_hds[] to serial_hd(), Peter Maydell, 2018/04/20