Re: [Qemu-devel] [PATCH] loader: Fix misaligned member access

[Peter Maydell]

On 23 April 2018 at 16:49, Philippe Mathieu-Daudé <address@hidden> wrote:
> I think I never noticed ldq_he_p(), good to know.
>
> $ git grep -E '(ld|st)._he_'
> net/checksum.c:130:        stw_he_p(&tcp->th_sum, 0);
> net/checksum.c:151:        stw_he_p(&udp->uh_sum, 0);
> util/bufferiszero.c:47:        uint64_t t = ldq_he_p(buf);
> util/bufferiszero.c:61:        t |= ldq_he_p(buf + len - 8);
>
> Not many users...

Well, it's fairly rare to have something that you want
to load in host endianness that isn't also aligned as
much as the host requires for it. We only want it here
because libfdt doesn't provide a ldq_fdt or something
like it ought to.

thanks
-- PMM