[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [RFC PATCH 28/33] job: Move job_finish_sync() to Job
From: |
Kevin Wolf |
Subject: |
[Qemu-devel] [RFC PATCH 28/33] job: Move job_finish_sync() to Job |
Date: |
Tue, 24 Apr 2018 17:25:10 +0200 |
block_job_finish_sync() doesn't contain anything block job specific any
more, so it can be moved to Job.
Signed-off-by: Kevin Wolf <address@hidden>
---
include/qemu/job.h | 9 +++++++++
blockjob.c | 55 +++++++++---------------------------------------------
job.c | 28 +++++++++++++++++++++++++++
3 files changed, 46 insertions(+), 46 deletions(-)
diff --git a/include/qemu/job.h b/include/qemu/job.h
index 6132cf8e21..c5a5d0cfdb 100644
--- a/include/qemu/job.h
+++ b/include/qemu/job.h
@@ -365,6 +365,15 @@ typedef void JobDeferToMainLoopFn(Job *job, void *opaque);
*/
void job_defer_to_main_loop(Job *job, JobDeferToMainLoopFn *fn, void *opaque);
+/**
+ * Synchronously finishes the given @job. If @finish is given, it is called to
+ * trigger completion or cancellation of the job.
+ *
+ * Returns 0 if the job is successfully completed, -ECANCELED if the job was
+ * cancelled before completing, and -errno in other error cases.
+ */
+int job_finish_sync(Job *job, void (*finish)(Job *, Error **errp), Error
**errp);
+
/* TODO To be removed from the public interface */
void job_state_transition(Job *job, JobStatus s1);
int job_apply_verb(Job *job, JobVerb bv, Error **errp);
diff --git a/blockjob.c b/blockjob.c
index f4010988d4..5d91070cd2 100644
--- a/blockjob.c
+++ b/blockjob.c
@@ -308,40 +308,6 @@ static int block_job_txn_apply(BlockJobTxn *txn, int
fn(BlockJob *), bool lock)
return rc;
}
-static int block_job_finish_sync(BlockJob *job,
- void (*finish)(BlockJob *, Error **errp),
- Error **errp)
-{
- Error *local_err = NULL;
- int ret;
-
- assert(blk_bs(job->blk)->job == job);
-
- job_ref(&job->job);
-
- if (finish) {
- finish(job, &local_err);
- }
- if (local_err) {
- error_propagate(errp, local_err);
- job_unref(&job->job);
- return -EBUSY;
- }
- /* job_drain calls job_enter, and it should be enough to induce progress
- * until the job completes or moves to the main thread.
- */
- while (!job->job.deferred_to_main_loop && !job_is_completed(&job->job)) {
- job_drain(&job->job);
- }
- while (!job_is_completed(&job->job)) {
- aio_poll(qemu_get_aio_context(), true);
- }
- ret = (job_is_cancelled(&job->job) && job->job.ret == 0)
- ? -ECANCELED : job->job.ret;
- job_unref(&job->job);
- return ret;
-}
-
static void block_job_completed_txn_abort(BlockJob *job)
{
AioContext *ctx;
@@ -376,7 +342,7 @@ static void block_job_completed_txn_abort(BlockJob *job)
ctx = blk_get_aio_context(other_job->blk);
if (!job_is_completed(&other_job->job)) {
assert(job_is_cancelled(&other_job->job));
- block_job_finish_sync(other_job, NULL, NULL);
+ job_finish_sync(&other_job->job, NULL, NULL);
}
job_finalize_single(&other_job->job);
aio_context_release(ctx);
@@ -529,16 +495,18 @@ void block_job_user_cancel(BlockJob *job, bool force,
Error **errp)
}
/* A wrapper around block_job_cancel() taking an Error ** parameter so it may
be
- * used with block_job_finish_sync() without the need for (rather nasty)
- * function pointer casts there. */
-static void block_job_cancel_err(BlockJob *job, Error **errp)
+ * used with job_finish_sync() without the need for (rather nasty) function
+ * pointer casts there. */
+static void block_job_cancel_err(Job *job, Error **errp)
{
- block_job_cancel(job, false);
+ BlockJob *bjob = container_of(job, BlockJob, job);
+ assert(is_block_job(job));
+ block_job_cancel(bjob, false);
}
int block_job_cancel_sync(BlockJob *job)
{
- return block_job_finish_sync(job, &block_job_cancel_err, NULL);
+ return job_finish_sync(&job->job, &block_job_cancel_err, NULL);
}
void block_job_cancel_sync_all(void)
@@ -554,14 +522,9 @@ void block_job_cancel_sync_all(void)
}
}
-static void block_job_complete(BlockJob *job, Error **errp)
-{
- job_complete(&job->job, errp);
-}
-
int block_job_complete_sync(BlockJob *job, Error **errp)
{
- return block_job_finish_sync(job, &block_job_complete, errp);
+ return job_finish_sync(&job->job, job_complete, errp);
}
void block_job_progress_update(BlockJob *job, uint64_t done)
diff --git a/job.c b/job.c
index dd68eb13f7..db3d8536f7 100644
--- a/job.c
+++ b/job.c
@@ -604,3 +604,31 @@ void job_defer_to_main_loop(Job *job, JobDeferToMainLoopFn
*fn, void *opaque)
aio_bh_schedule_oneshot(qemu_get_aio_context(),
job_defer_to_main_loop_bh, data);
}
+
+int job_finish_sync(Job *job, void (*finish)(Job *, Error **errp), Error
**errp)
+{
+ Error *local_err = NULL;
+ int ret;
+
+ job_ref(job);
+
+ if (finish) {
+ finish(job, &local_err);
+ }
+ if (local_err) {
+ error_propagate(errp, local_err);
+ job_unref(job);
+ return -EBUSY;
+ }
+ /* job_drain calls job_enter, and it should be enough to induce progress
+ * until the job completes or moves to the main thread. */
+ while (!job->deferred_to_main_loop && !job_is_completed(job)) {
+ job_drain(job);
+ }
+ while (!job_is_completed(job)) {
+ aio_poll(qemu_get_aio_context(), true);
+ }
+ ret = (job_is_cancelled(job) && job->ret == 0) ? -ECANCELED : job->ret;
+ job_unref(job);
+ return ret;
+}
--
2.13.6
- [Qemu-devel] [RFC PATCH 16/33] job: Move defer_to_main_loop to Job, (continued)
- [Qemu-devel] [RFC PATCH 16/33] job: Move defer_to_main_loop to Job, Kevin Wolf, 2018/04/24
- [Qemu-devel] [RFC PATCH 22/33] blockjob: Split block_job_event_pending(), Kevin Wolf, 2018/04/24
- [Qemu-devel] [RFC PATCH 21/33] job: Move BlockJobCreateFlags to Job, Kevin Wolf, 2018/04/24
- [Qemu-devel] [RFC PATCH 18/33] job: Add job_sleep_ns(), Kevin Wolf, 2018/04/24
- [Qemu-devel] [RFC PATCH 20/33] job: Replace BlockJob.completed with job_is_completed(), Kevin Wolf, 2018/04/24
- [Qemu-devel] [RFC PATCH 23/33] job: Add job_event_*(), Kevin Wolf, 2018/04/24
- [Qemu-devel] [RFC PATCH 19/33] job: Move pause/resume functions to Job, Kevin Wolf, 2018/04/24
- [Qemu-devel] [RFC PATCH 25/33] job: Convert block_job_cancel_async() to Job, Kevin Wolf, 2018/04/24
- [Qemu-devel] [RFC PATCH 24/33] job: Move single job finalisation to Job, Kevin Wolf, 2018/04/24
- [Qemu-devel] [RFC PATCH 26/33] job: Add job_drain(), Kevin Wolf, 2018/04/24
- [Qemu-devel] [RFC PATCH 28/33] job: Move job_finish_sync() to Job,
Kevin Wolf <=
- [Qemu-devel] [RFC PATCH 27/33] job: Move .complete callback to Job, Kevin Wolf, 2018/04/24
- [Qemu-devel] [RFC PATCH 17/33] job: Move coroutine and related code to Job, Kevin Wolf, 2018/04/24
- [Qemu-devel] [RFC PATCH 32/33] job: Add job_yield(), Kevin Wolf, 2018/04/24
- [Qemu-devel] [RFC PATCH 33/33] job: Add job_dismiss(), Kevin Wolf, 2018/04/24
- [Qemu-devel] [RFC PATCH 29/33] job: Switch transactions to JobTxn, Kevin Wolf, 2018/04/24
- [Qemu-devel] [RFC PATCH 31/33] job: Move completion and cancellation to Job, Kevin Wolf, 2018/04/24
- [Qemu-devel] [RFC PATCH 30/33] job: Move transactions to Job, Kevin Wolf, 2018/04/24
- Re: [Qemu-devel] [RFC PATCH 00/33] Generic background jobs, no-reply, 2018/04/24
- Re: [Qemu-devel] [RFC PATCH 00/33] Generic background jobs, Eric Blake, 2018/04/24