[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 01/16] migration: introduce postcopy-blocktime ca
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [Qemu-devel] [PULL 01/16] migration: introduce postcopy-blocktime capability |
Date: |
Thu, 26 Apr 2018 13:24:14 +0100 |
User-agent: |
Mutt/1.9.5 (2018-04-13) |
* Eric Blake (address@hidden) wrote:
> On 04/25/2018 03:03 PM, Dr. David Alan Gilbert (git) wrote:
> > From: Alexey Perevalov <address@hidden>
> >
> > Right now it could be used on destination side to
> > enable vCPU blocktime calculation for postcopy live migration.
> > vCPU blocktime - it's time since vCPU thread was put into
> > interruptible sleep, till memory page was copied and thread awake.
> >
> > Reviewed-by: Dr. David Alan Gilbert <address@hidden>
> > Signed-off-by: Alexey Perevalov <address@hidden>
> > Reviewed-by: Juan Quintela <address@hidden>
> > Signed-off-by: Juan Quintela <address@hidden>
> > Message-Id: <address@hidden>
> > Signed-off-by: Dr. David Alan Gilbert <address@hidden>
> > ---
>
> > +++ b/qapi/migration.json
> > @@ -354,16 +354,20 @@
> > #
> > # @x-multifd: Use more than one fd for migration (since 2.11)
> > #
> > +#
> > # @dirty-bitmaps: If enabled, QEMU will migrate named dirty bitmaps.
>
> Why is the extra blank line added here? Doesn't hold up the pull
> request, but might be worth a trivial followup patch.
I think it's just a merge artifact; this patch has been around for a few
versions so has been bumped down that list a few times.
OK, I'll do that.
Dave
> > # (since 2.12)
> > #
> > +# @postcopy-blocktime: Calculate downtime for postcopy live migration
> > +# (since 2.13)
> > +#
> > # Since: 1.2
> > ##
> > { 'enum': 'MigrationCapability',
> > 'data': ['xbzrle', 'rdma-pin-all', 'auto-converge', 'zero-blocks',
> > 'compress', 'events', 'postcopy-ram', 'x-colo', 'release-ram',
> > 'block', 'return-path', 'pause-before-switchover', 'x-multifd',
> > - 'dirty-bitmaps' ] }
> > + 'dirty-bitmaps', 'postcopy-blocktime' ] }
> >
> > ##
> > # @MigrationCapabilityStatus:
> >
>
> --
> Eric Blake, Principal Software Engineer
> Red Hat, Inc. +1-919-301-3266
> Virtualization: qemu.org | libvirt.org
>
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK
- [Qemu-devel] [PULL 00/16] migration queue, Dr. David Alan Gilbert (git), 2018/04/25
- [Qemu-devel] [PULL 04/16] migration: postcopy_blocktime documentation, Dr. David Alan Gilbert (git), 2018/04/25
- [Qemu-devel] [PULL 01/16] migration: introduce postcopy-blocktime capability, Dr. David Alan Gilbert (git), 2018/04/25
- [Qemu-devel] [PULL 02/16] migration: add postcopy blocktime ctx into MigrationIncomingState, Dr. David Alan Gilbert (git), 2018/04/25
- [Qemu-devel] [PULL 05/16] migration: add blocktime calculation into migration-test, Dr. David Alan Gilbert (git), 2018/04/25
- [Qemu-devel] [PULL 08/16] migration: stop compression to allocate and free memory frequently, Dr. David Alan Gilbert (git), 2018/04/25
- [Qemu-devel] [PULL 07/16] migration: stop compressing page in migration thread, Dr. David Alan Gilbert (git), 2018/04/25
- [Qemu-devel] [PULL 09/16] migration: stop decompression to allocate and free memory frequently, Dr. David Alan Gilbert (git), 2018/04/25
- [Qemu-devel] [PULL 06/16] migration: add postcopy total blocktime into query-migrate, Dr. David Alan Gilbert (git), 2018/04/25
- [Qemu-devel] [PULL 15/16] migration: introduce save_normal_page(), Dr. David Alan Gilbert (git), 2018/04/25
- [Qemu-devel] [PULL 14/16] migration: move calling save_zero_page to the common place, Dr. David Alan Gilbert (git), 2018/04/25