[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 4/4] qapi: discriminate CpuInfoFast on SysEmu
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v2 4/4] qapi: discriminate CpuInfoFast on SysEmuTarget, not CpuInfoArch |
Date: |
Thu, 26 Apr 2018 14:45:58 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 |
On 04/26/2018 02:41 PM, Eric Blake wrote:
> I also like that this approach is introspectible via 'query-qmp-schema'
> - if 'query-cpus-fast' has the "target" member, then you know that it is
> fixed (you can ignore "arch" in that case, even though you know it
> works); if it lacks "target", you know that "arch":"s390x" is the only
Correcting myself: "arch":"s390" is the magic string for older qemu; and
your mapping function from target to arch keeps it that way, so that
older clients not aware of "target":"s390x" still get the right behavior.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v2 2/4] qapi: add SysEmuTarget to "common.json", (continued)