[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 4/5] qobject: modify qobject_ref() to return
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH v6 4/5] qobject: modify qobject_ref() to return obj |
Date: |
Fri, 27 Apr 2018 10:50:06 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) |
Marc-André Lureau <address@hidden> writes:
> For convenience and clarity, make it possible to call qobject_ref() at
> the time when the reference is associated with a variable, or
> argument, by making qobject_ref() return the same pointer as given.
For me, the text doesn't make clear that you went through all the
callers. What about inserting "Use that to simplify the callers" here?
> Signed-off-by: Marc-André Lureau <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>
Preferably with a clarified commit message:
Reviewed-by: Markus Armbruster <address@hidden>
- Re: [Qemu-devel] [PATCH v6 1/5] qobject: ensure base is at offset 0, (continued)
- [Qemu-devel] [PATCH v6 2/5] qobject: use a QObjectBase_ struct, Marc-André Lureau, 2018/04/19
- [Qemu-devel] [PATCH v6 5/5] qobject: modify qobject_ref() to assert on NULL, Marc-André Lureau, 2018/04/19
- [Qemu-devel] [PATCH v6 4/5] qobject: modify qobject_ref() to return obj, Marc-André Lureau, 2018/04/19
- [Qemu-devel] [PATCH v6 3/5] qobject: replace qobject_incref/QINCREF qobject_decref/QDECREF, Marc-André Lureau, 2018/04/19
- Re: [Qemu-devel] [PATCH v6 0/5] Simplify qobject refcount, Eric Blake, 2018/04/19