[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] ccid-card: include libcacard.h only
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [PATCH v2] ccid-card: include libcacard.h only |
Date: |
Fri, 27 Apr 2018 10:58:09 +0200 |
User-agent: |
NeoMutt/20180323 |
On Tue, Apr 03, 2018 at 12:34:37PM +0200, Michal Privoznik wrote:
> When trying to build with latest libcacard-2.5.1, I hit the
> following error:
>
> In file included from hw/usb/ccid-card-passthru.c:12:0:
> /usr/include/cacard/vscard_common.h:26:2: error: #warning "Only <libcacard.h>
> can be included directly" [-Werror=cpp]
> #warning "Only <libcacard.h> can be included directly"
>
> While it was fixed in libcacard upstream (so that individual
> files can be included directly), it doesn't make much sense.
> Let's switch to including the main libcacard.h and also require
> at least libcacard-2.5.1 which introduced it. It's available
> since late 2015.
Added to usb queue.
thanks,
Gerd