[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 13/14] spice: add cursor_dmabuf support
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PULL 13/14] spice: add cursor_dmabuf support |
Date: |
Fri, 27 Apr 2018 14:16:31 +0100 |
On 12 March 2018 at 09:14, Gerd Hoffmann <address@hidden> wrote:
> Add support for cursor dmabufs. qemu has to render the cursor for
> that, so in case a cursor is present qemu allocates a new dmabuf, blits
> the scanout, blends in the pointer and passes on the new dmabuf to
> spice-server. Without cursor qemu continues to simply pass on the
> scanout dmabuf as-is.
>
> Signed-off-by: Gerd Hoffmann <address@hidden>
> Reviewed-by: Marc-André Lureau <address@hidden>
> Message-id: address@hidden
> +static void qemu_spice_gl_cursor_position(DisplayChangeListener *dcl,
> + uint32_t pos_x, uint32_t pos_y)
> +{
> + SimpleSpiceDisplay *ssd = container_of(dcl, SimpleSpiceDisplay, dcl);
> +
> + ssd->ptr_x = pos_x;
> + ssd->ptr_y = pos_y;
Is it safe to write to these fields of ssd without holding
ssd->lock ? Coverity thinks it might not be (CID 1390631) because
we do take the lock to update them in display_mouse_set().
thanks
-- PMM