[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 5/5] qapi: deprecate CpuInfoFast.arch
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v3 5/5] qapi: deprecate CpuInfoFast.arch |
Date: |
Fri, 27 Apr 2018 14:55:44 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 |
On 04/27/2018 02:28 PM, Laszlo Ersek wrote:
> The TARGET_BASE_ARCH values from "configure" don't all map to the
> @CpuInfoArch enum constants; in particular "s390x" from the former does
> not match @s390 in the latter. Clients are known to rely on the @s390
> constant specifically, so we can't change it silently. Instead, deprecate
> the @address@hidden member (in favor of @address@hidden) using the
> regular deprecation process.
>
> (No deprecation reminder is added to sysemu_target_to_cpuinfo_arch(): once
> @address@hidden is removed, the assignment expression that calls
> sysemu_target_to_cpuinfo_arch() from qmp_query_cpus_fast() will have to
> disappear; in turn the static function left without callers will also
> break the build, thus it'll have to go.)
>
> Cc: "Daniel P. Berrange" <address@hidden>
> Cc: Eric Blake <address@hidden>
> Cc: Markus Armbruster <address@hidden>
> Signed-off-by: Laszlo Ersek <address@hidden>
> ---
>
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v3 0/5] qapi: introduce the SysEmuTarget enumeration, Laszlo Ersek, 2018/04/27
- [Qemu-devel] [PATCH v3 3/5] qapi: change the type of TargetInfo.arch from string to enum SysEmuTarget, Laszlo Ersek, 2018/04/27
- [Qemu-devel] [PATCH v3 4/5] qapi: discriminate CpuInfoFast on SysEmuTarget, not CpuInfoArch, Laszlo Ersek, 2018/04/27
- [Qemu-devel] [PATCH v3 5/5] qapi: deprecate CpuInfoFast.arch, Laszlo Ersek, 2018/04/27
- Re: [Qemu-devel] [PATCH v3 5/5] qapi: deprecate CpuInfoFast.arch,
Eric Blake <=
- [Qemu-devel] [PATCH v3 1/5] qapi: fill in CpuInfoFast.arch in query-cpus-fast, Laszlo Ersek, 2018/04/27
- [Qemu-devel] [PATCH v3 2/5] qapi: add SysEmuTarget to "common.json", Laszlo Ersek, 2018/04/27