[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH qemu] qom: Document qom/device-list-properties i
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH qemu] qom: Document qom/device-list-properties implementation specific |
Date: |
Wed, 2 May 2018 11:50:32 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 |
On 02/05/2018 11:33, Alexey Kardashevskiy wrote:
>>>>>> +# Note: the handler creates an object, enumerates properties and
>>>>>> destroys
>>>>>> +# the object so it only lists properties created in
>>>>>> TypeInfo::instance_init().
>>>>>> +# Since the instance_init() callback of the device object adds
>>>>>> +# DeviceClass::props as object properties, they will be listed as well.
>
> There are roughly 400 of realize(), this is will take a bit of time :)
> imho what it does belongs to .json, why it does exactly that belongs to the
> git commit log. I'll walk through the realize() hook though, educate
> myself, at least :)
Cheer up, there are only 300 callers of object_property_add_* (apart
from object_property_add_child which is generally not an issue). You
could look at those instead. :)
Seriously, I think the problem with the comment is only that the reader
most likely doesn't care about instance_init() or props, as those are
QEMU implementation details.
Paolo
- Re: [Qemu-devel] [PATCH qemu] qom: Document qom/device-list-properties implementation specific, Eric Blake, 2018/05/01
- Re: [Qemu-devel] [PATCH qemu] qom: Document qom/device-list-properties implementation specific, Markus Armbruster, 2018/05/02
- Re: [Qemu-devel] [PATCH qemu] qom: Document qom/device-list-properties implementation specific, Paolo Bonzini, 2018/05/02
- Re: [Qemu-devel] [PATCH qemu] qom: Document qom/device-list-properties implementation specific, Markus Armbruster, 2018/05/02
- Re: [Qemu-devel] [PATCH qemu] qom: Document qom/device-list-properties implementation specific, Paolo Bonzini, 2018/05/02
- Re: [Qemu-devel] [PATCH qemu] qom: Document qom/device-list-properties implementation specific, Markus Armbruster, 2018/05/02
- Re: [Qemu-devel] [PATCH qemu] qom: Document qom/device-list-properties implementation specific, Paolo Bonzini, 2018/05/02