[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 00/67] include path cleanup
|
From: |
no-reply |
|
Subject: |
Re: [Qemu-devel] [PATCH 00/67] include path cleanup |
|
Date: |
Thu, 3 May 2018 13:58:20 -0700 (PDT) |
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PATCH 00/67] include path cleanup
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag] patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
dda9647d70 make: simplify source include path
b158a719f3 linux-user: add include directory header
b2ae9844c1 tcg: use include "translate-all.h" consistently
3613ec1453 target/s390x: add include directory header
d00910afb1 hw/s390x: use target headers explicitly
194f6f9974 kvm: use include "kvm_ppc.h" consistently
256581c1be hw/net: add include directory header
440e14b88a hw/s390x: add include directory headers
84a81cbde5 hw/ppc: add target headers explicitly
87bebef613 target/riscv: add include directory header
d02cccc221 kvm: use include "kvm_i386.h" consistently
f9543ea9d8 tcg: use include "tcg-gvec-desc.h.h" consistently
52a7685f6f amd_iommu: add include directory header
18b966a8fe amd_iommu: add include directory header
1f841bece5 target/ppc: add include directory headers
3d6945bd6b target/arm: add include directory headers
863bb03c5a hyperv: add include directory header
1011069886 hmp: add include directory header
5f1be83b0f kvm_XXX: add include directory headers
a4f45a0012 virtio-pci: add include directory header
8e2f2e471e tcg-op: use include "tcg.h" consistently
d9c41e578e cpu-qom: add include directory headers
ce17c41200 tcg: add include directory headers
1690189b5e tcg-ldst.inc.c: replace command line flags with preprocessor
5143bc145e translate-all: add include directory header
cd074d2b2c tcg: use include "tcg.h" consistently
3418bf3073 tcg-pool.inc.c: replace command line flags with preprocessor
653e93fefe trace: add include directory headers
76e207bfb1 target: replace command line flags with preprocessor
81d9592c44 helper: replace command line flags with preprocessor
287a3a85aa tcg: add include directory headers
0912dbb70e migration: add include directory headers
e234a2f0a3 hw/usb: add include directory header
0855ad7432 hw/ppc: add include directory headers
bff5bf26d6 hw/net: add include directory header
523897142f ui: add include directory header
a86a80bd28 target/cris: add include directory header
bc35b6c9a9 audio: add include directory header
c5c49795ca fsdev: add include directory headers
2184da2487 9pfs: add include directory headers
cebd0e6d5d replication: add include directory header
7fd6a43e9c cpu: replace command line flags with preprocessor
8d5900280a arch_init: sort architectures
5f3be2f16f net: add include directory headers
26e688947b slirp: add include directory headers
677b5a5222 ui: use local path for local headers
a2e9d7b6d0 trace: use local path for local headers
ab8e11dbb1 tests: relative include for child directory
2505961862 xtensa: relative include for parent directory
0561f465a9 qga: use local path for local headers
f02e149685 colo: use local path for local headers
f63ff1c1e5 migration: use local path for local headers
0e2942e37a usb: use local path for local headers
a17070acf1 sd: fix up include
804ef03fb9 vhost-scsi: drop an unused include
eded79b7c5 ppc: use local path for local headers
e352ed36c5 rocker: drop an unused include
303a3d4072 e1000e: use local path for local headers
4df0916e5c ioapic: fix up includes
4f533ce25a ide: use local path for local headers
3ad03c679d display: use local path for local headers
e56cb2ab7c trace: use local path for local headers
711e6fe8f8 migration: drop an unused include, add a used one
fdbc0e45c0 s390x: drop an unused include
abd9bbe5ea hppa: use local path for local headers
6ce2ed96c7 crypto: use local path for local headers
d5cd88766c block: use local path for local headers
=== OUTPUT BEGIN ===
Checking PATCH 1/67: block: use local path for local headers...
Checking PATCH 2/67: crypto: use local path for local headers...
Checking PATCH 3/67: hppa: use local path for local headers...
Checking PATCH 4/67: s390x: drop an unused include...
Checking PATCH 5/67: migration: drop an unused include, add a used one...
Checking PATCH 6/67: trace: use local path for local headers...
Checking PATCH 7/67: display: use local path for local headers...
Checking PATCH 8/67: ide: use local path for local headers...
Checking PATCH 9/67: ioapic: fix up includes...
Checking PATCH 10/67: e1000e: use local path for local headers...
Checking PATCH 11/67: rocker: drop an unused include...
Checking PATCH 12/67: ppc: use local path for local headers...
Checking PATCH 13/67: vhost-scsi: drop an unused include...
Checking PATCH 14/67: sd: fix up include...
Checking PATCH 15/67: usb: use local path for local headers...
Checking PATCH 16/67: migration: use local path for local headers...
Checking PATCH 17/67: colo: use local path for local headers...
Checking PATCH 18/67: qga: use local path for local headers...
Checking PATCH 19/67: xtensa: relative include for parent directory...
Checking PATCH 20/67: tests: relative include for child directory...
Checking PATCH 21/67: trace: use local path for local headers...
Checking PATCH 22/67: ui: use local path for local headers...
Checking PATCH 23/67: slirp: add include directory headers...
Checking PATCH 24/67: net: add include directory headers...
Checking PATCH 25/67: arch_init: sort architectures...
Checking PATCH 26/67: cpu: replace command line flags with preprocessor...
Checking PATCH 27/67: replication: add include directory header...
Checking PATCH 28/67: 9pfs: add include directory headers...
Checking PATCH 29/67: fsdev: add include directory headers...
Checking PATCH 30/67: audio: add include directory header...
Checking PATCH 31/67: target/cris: add include directory header...
Checking PATCH 32/67: ui: add include directory header...
Checking PATCH 33/67: hw/net: add include directory header...
Checking PATCH 34/67: hw/ppc: add include directory headers...
Checking PATCH 35/67: hw/usb: add include directory header...
Checking PATCH 36/67: migration: add include directory headers...
Checking PATCH 37/67: tcg: add include directory headers...
Checking PATCH 38/67: helper: replace command line flags with preprocessor...
Checking PATCH 39/67: target: replace command line flags with preprocessor...
ERROR: spaces required around that '/' (ctx:VxV)
#34: FILE: include/target-dir.h:14:
+#define TARGET_DIR_PREFIX ../target/alpha
^
ERROR: spaces required around that '/' (ctx:VxV)
#34: FILE: include/target-dir.h:14:
+#define TARGET_DIR_PREFIX ../target/alpha
^
ERROR: Macros with complex values should be enclosed in parenthesis
#34: FILE: include/target-dir.h:14:
+#define TARGET_DIR_PREFIX ../target/alpha
ERROR: spaces required around that '/' (ctx:VxV)
#36: FILE: include/target-dir.h:16:
+#define TARGET_DIR_PREFIX ../target/arm
^
ERROR: spaces required around that '/' (ctx:VxV)
#36: FILE: include/target-dir.h:16:
+#define TARGET_DIR_PREFIX ../target/arm
^
ERROR: Macros with complex values should be enclosed in parenthesis
#36: FILE: include/target-dir.h:16:
+#define TARGET_DIR_PREFIX ../target/arm
ERROR: spaces required around that '/' (ctx:VxV)
#38: FILE: include/target-dir.h:18:
+#define TARGET_DIR_PREFIX ../target/cris
^
ERROR: spaces required around that '/' (ctx:VxV)
#38: FILE: include/target-dir.h:18:
+#define TARGET_DIR_PREFIX ../target/cris
^
ERROR: Macros with complex values should be enclosed in parenthesis
#38: FILE: include/target-dir.h:18:
+#define TARGET_DIR_PREFIX ../target/cris
ERROR: spaces required around that '/' (ctx:VxV)
#40: FILE: include/target-dir.h:20:
+#define TARGET_DIR_PREFIX ../target/hppa
^
ERROR: spaces required around that '/' (ctx:VxV)
#40: FILE: include/target-dir.h:20:
+#define TARGET_DIR_PREFIX ../target/hppa
^
ERROR: Macros with complex values should be enclosed in parenthesis
#40: FILE: include/target-dir.h:20:
+#define TARGET_DIR_PREFIX ../target/hppa
ERROR: spaces required around that '/' (ctx:VxV)
#42: FILE: include/target-dir.h:22:
+#define TARGET_DIR_PREFIX ../target/i386
^
ERROR: spaces required around that '/' (ctx:VxV)
#42: FILE: include/target-dir.h:22:
+#define TARGET_DIR_PREFIX ../target/i386
^
ERROR: Macros with complex values should be enclosed in parenthesis
#42: FILE: include/target-dir.h:22:
+#define TARGET_DIR_PREFIX ../target/i386
ERROR: spaces required around that '/' (ctx:VxV)
#44: FILE: include/target-dir.h:24:
+#define TARGET_DIR_PREFIX ../target/lm32
^
ERROR: spaces required around that '/' (ctx:VxV)
#44: FILE: include/target-dir.h:24:
+#define TARGET_DIR_PREFIX ../target/lm32
^
ERROR: Macros with complex values should be enclosed in parenthesis
#44: FILE: include/target-dir.h:24:
+#define TARGET_DIR_PREFIX ../target/lm32
ERROR: spaces required around that '/' (ctx:VxV)
#46: FILE: include/target-dir.h:26:
+#define TARGET_DIR_PREFIX ../target/m68k
^
ERROR: spaces required around that '/' (ctx:VxV)
#46: FILE: include/target-dir.h:26:
+#define TARGET_DIR_PREFIX ../target/m68k
^
ERROR: Macros with complex values should be enclosed in parenthesis
#46: FILE: include/target-dir.h:26:
+#define TARGET_DIR_PREFIX ../target/m68k
ERROR: spaces required around that '/' (ctx:VxV)
#48: FILE: include/target-dir.h:28:
+#define TARGET_DIR_PREFIX ../target/microblaze
^
ERROR: spaces required around that '/' (ctx:VxV)
#48: FILE: include/target-dir.h:28:
+#define TARGET_DIR_PREFIX ../target/microblaze
^
ERROR: Macros with complex values should be enclosed in parenthesis
#48: FILE: include/target-dir.h:28:
+#define TARGET_DIR_PREFIX ../target/microblaze
ERROR: spaces required around that '/' (ctx:VxV)
#50: FILE: include/target-dir.h:30:
+#define TARGET_DIR_PREFIX ../target/mips
^
ERROR: spaces required around that '/' (ctx:VxV)
#50: FILE: include/target-dir.h:30:
+#define TARGET_DIR_PREFIX ../target/mips
^
ERROR: Macros with complex values should be enclosed in parenthesis
#50: FILE: include/target-dir.h:30:
+#define TARGET_DIR_PREFIX ../target/mips
ERROR: spaces required around that '/' (ctx:VxV)
#52: FILE: include/target-dir.h:32:
+#define TARGET_DIR_PREFIX ../target/moxie
^
ERROR: spaces required around that '/' (ctx:VxV)
#52: FILE: include/target-dir.h:32:
+#define TARGET_DIR_PREFIX ../target/moxie
^
ERROR: Macros with complex values should be enclosed in parenthesis
#52: FILE: include/target-dir.h:32:
+#define TARGET_DIR_PREFIX ../target/moxie
ERROR: spaces required around that '/' (ctx:VxV)
#54: FILE: include/target-dir.h:34:
+#define TARGET_DIR_PREFIX ../target/nios2
^
ERROR: spaces required around that '/' (ctx:VxV)
#54: FILE: include/target-dir.h:34:
+#define TARGET_DIR_PREFIX ../target/nios2
^
ERROR: Macros with complex values should be enclosed in parenthesis
#54: FILE: include/target-dir.h:34:
+#define TARGET_DIR_PREFIX ../target/nios2
ERROR: spaces required around that '/' (ctx:VxV)
#56: FILE: include/target-dir.h:36:
+#define TARGET_DIR_PREFIX ../target/openrisc
^
ERROR: spaces required around that '/' (ctx:VxV)
#56: FILE: include/target-dir.h:36:
+#define TARGET_DIR_PREFIX ../target/openrisc
^
ERROR: Macros with complex values should be enclosed in parenthesis
#56: FILE: include/target-dir.h:36:
+#define TARGET_DIR_PREFIX ../target/openrisc
ERROR: spaces required around that '/' (ctx:VxV)
#58: FILE: include/target-dir.h:38:
+#define TARGET_DIR_PREFIX ../target/ppc
^
ERROR: spaces required around that '/' (ctx:VxV)
#58: FILE: include/target-dir.h:38:
+#define TARGET_DIR_PREFIX ../target/ppc
^
ERROR: Macros with complex values should be enclosed in parenthesis
#58: FILE: include/target-dir.h:38:
+#define TARGET_DIR_PREFIX ../target/ppc
ERROR: spaces required around that '/' (ctx:VxV)
#60: FILE: include/target-dir.h:40:
+#define TARGET_DIR_PREFIX ../target/riscv
^
ERROR: spaces required around that '/' (ctx:VxV)
#60: FILE: include/target-dir.h:40:
+#define TARGET_DIR_PREFIX ../target/riscv
^
ERROR: Macros with complex values should be enclosed in parenthesis
#60: FILE: include/target-dir.h:40:
+#define TARGET_DIR_PREFIX ../target/riscv
ERROR: spaces required around that '/' (ctx:VxV)
#62: FILE: include/target-dir.h:42:
+#define TARGET_DIR_PREFIX ../target/s390x
^
ERROR: spaces required around that '/' (ctx:VxV)
#62: FILE: include/target-dir.h:42:
+#define TARGET_DIR_PREFIX ../target/s390x
^
ERROR: Macros with complex values should be enclosed in parenthesis
#62: FILE: include/target-dir.h:42:
+#define TARGET_DIR_PREFIX ../target/s390x
ERROR: spaces required around that '/' (ctx:VxV)
#64: FILE: include/target-dir.h:44:
+#define TARGET_DIR_PREFIX ../target/sh4
^
ERROR: spaces required around that '/' (ctx:VxV)
#64: FILE: include/target-dir.h:44:
+#define TARGET_DIR_PREFIX ../target/sh4
^
ERROR: Macros with complex values should be enclosed in parenthesis
#64: FILE: include/target-dir.h:44:
+#define TARGET_DIR_PREFIX ../target/sh4
ERROR: spaces required around that '/' (ctx:VxV)
#66: FILE: include/target-dir.h:46:
+#define TARGET_DIR_PREFIX ../target/sparc
^
ERROR: spaces required around that '/' (ctx:VxV)
#66: FILE: include/target-dir.h:46:
+#define TARGET_DIR_PREFIX ../target/sparc
^
ERROR: Macros with complex values should be enclosed in parenthesis
#66: FILE: include/target-dir.h:46:
+#define TARGET_DIR_PREFIX ../target/sparc
ERROR: spaces required around that '/' (ctx:VxV)
#68: FILE: include/target-dir.h:48:
+#define TARGET_DIR_PREFIX ../target/unicore32
^
ERROR: spaces required around that '/' (ctx:VxV)
#68: FILE: include/target-dir.h:48:
+#define TARGET_DIR_PREFIX ../target/unicore32
^
ERROR: Macros with complex values should be enclosed in parenthesis
#68: FILE: include/target-dir.h:48:
+#define TARGET_DIR_PREFIX ../target/unicore32
ERROR: spaces required around that '/' (ctx:VxV)
#70: FILE: include/target-dir.h:50:
+#define TARGET_DIR_PREFIX ../target/tilegx
^
ERROR: spaces required around that '/' (ctx:VxV)
#70: FILE: include/target-dir.h:50:
+#define TARGET_DIR_PREFIX ../target/tilegx
^
ERROR: Macros with complex values should be enclosed in parenthesis
#70: FILE: include/target-dir.h:50:
+#define TARGET_DIR_PREFIX ../target/tilegx
ERROR: spaces required around that '/' (ctx:VxV)
#72: FILE: include/target-dir.h:52:
+#define TARGET_DIR_PREFIX ../target/tricore
^
ERROR: spaces required around that '/' (ctx:VxV)
#72: FILE: include/target-dir.h:52:
+#define TARGET_DIR_PREFIX ../target/tricore
^
ERROR: Macros with complex values should be enclosed in parenthesis
#72: FILE: include/target-dir.h:52:
+#define TARGET_DIR_PREFIX ../target/tricore
ERROR: spaces required around that '/' (ctx:VxV)
#74: FILE: include/target-dir.h:54:
+#define TARGET_DIR_PREFIX ../target/xtensa
^
ERROR: spaces required around that '/' (ctx:VxV)
#74: FILE: include/target-dir.h:54:
+#define TARGET_DIR_PREFIX ../target/xtensa
^
ERROR: Macros with complex values should be enclosed in parenthesis
#74: FILE: include/target-dir.h:54:
+#define TARGET_DIR_PREFIX ../target/xtensa
ERROR: spaces required around that '/' (ctx:VxV)
#81: FILE: include/target-dir.h:61:
+#define TARGET_DIR(file) TARGET_DIR_STRING(TARGET_DIR_PREFIX/file)
^
total: 64 errors, 0 warnings, 63 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 40/67: trace: add include directory headers...
Checking PATCH 41/67: tcg-pool.inc.c: replace command line flags with
preprocessor...
Checking PATCH 42/67: tcg: use include "tcg.h" consistently...
Checking PATCH 43/67: translate-all: add include directory header...
Checking PATCH 44/67: tcg-ldst.inc.c: replace command line flags with
preprocessor...
Checking PATCH 45/67: tcg: add include directory headers...
Checking PATCH 46/67: cpu-qom: add include directory headers...
Checking PATCH 47/67: tcg-op: use include "tcg.h" consistently...
Checking PATCH 48/67: virtio-pci: add include directory header...
Checking PATCH 49/67: kvm_XXX: add include directory headers...
Checking PATCH 50/67: hmp: add include directory header...
Checking PATCH 51/67: hyperv: add include directory header...
Checking PATCH 52/67: target/arm: add include directory headers...
Checking PATCH 53/67: target/ppc: add include directory headers...
Checking PATCH 54/67: amd_iommu: add include directory header...
Checking PATCH 55/67: amd_iommu: add include directory header...
Checking PATCH 56/67: tcg: use include "tcg-gvec-desc.h.h" consistently...
Checking PATCH 57/67: kvm: use include "kvm_i386.h" consistently...
Checking PATCH 58/67: target/riscv: add include directory header...
Checking PATCH 59/67: hw/ppc: add target headers explicitly...
Checking PATCH 60/67: hw/s390x: add include directory headers...
Checking PATCH 61/67: hw/net: add include directory header...
Checking PATCH 62/67: kvm: use include "kvm_ppc.h" consistently...
Checking PATCH 63/67: hw/s390x: use target headers explicitly...
Checking PATCH 64/67: target/s390x: add include directory header...
Checking PATCH 65/67: tcg: use include "translate-all.h" consistently...
Checking PATCH 66/67: linux-user: add include directory header...
Checking PATCH 67/67: make: simplify source include path...
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden
- Re: [Qemu-devel] [PATCH 62/67] kvm: use include "kvm_ppc.h" consistently, (continued)
- [Qemu-devel] [PATCH 63/67] hw/s390x: use target headers explicitly, Michael S. Tsirkin, 2018/05/03
- [Qemu-devel] [PATCH 64/67] target/s390x: add include directory header, Michael S. Tsirkin, 2018/05/03
- [Qemu-devel] [PATCH 65/67] tcg: use include "translate-all.h" consistently, Michael S. Tsirkin, 2018/05/03
- [Qemu-devel] [PATCH 66/67] linux-user: add include directory header, Michael S. Tsirkin, 2018/05/03
- [Qemu-devel] [PATCH 67/67] make: simplify source include path, Michael S. Tsirkin, 2018/05/03
- Re: [Qemu-devel] [PATCH 00/67] include path cleanup,
no-reply <=
- Re: [Qemu-devel] [PATCH 00/67] include path cleanup, no-reply, 2018/05/03
- Re: [Qemu-devel] [PATCH 00/67] include path cleanup, no-reply, 2018/05/03
- Re: [Qemu-devel] [PATCH 00/67] include path cleanup, no-reply, 2018/05/03
- Re: [Qemu-devel] [PATCH 00/67] include path cleanup, Paolo Bonzini, 2018/05/09