Re: [Qemu-devel] [PATCH 27/67] replication: add include directory header

[Michael S. Tsirkin]

On Fri, May 04, 2018 at 10:29:24AM +0100, Daniel P. Berrangé wrote:
> On Thu, May 03, 2018 at 10:51:05PM +0300, Michael S. Tsirkin wrote:
> > This way it is easier to find using standard rules.
> > 
> > Signed-off-by: Michael S. Tsirkin <address@hidden>
> > ---
> >  include/replication.h | 1 +
> >  1 file changed, 1 insertion(+)
> >  create mode 100644 include/replication.h
> > 
> > diff --git a/include/replication.h b/include/replication.h
> > new file mode 100644
> > index 0000000..2f40e8e
> > --- /dev/null
> > +++ b/include/replication.h
> > @@ -0,0 +1 @@
> > +#include_next "../replication.h"
> 
> I think this is really crazy. If we want the headers to be accessible
> via the include/ directory, lets move them to the include/ directory,
> not create wrappers that point back to the source directory.
> 
> Regards,
> Daniel

True. I did that initially. However I think maintainers should do this
otherwise this amounts to moving internal headers to include/ wholesale.

At least this patch will stop proliferation of new headers in source
directories.

And with these patches external headers in source directory are
easy to identify.

> -- 
> |: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
> |: https://libvirt.org         -o-            https://fstop138.berrange.com :|
> |: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|