[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 36/67] migration: add include directory headers
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-devel] [PATCH 36/67] migration: add include directory headers |
Date: |
Tue, 8 May 2018 09:56:43 -0300 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 |
On 05/08/2018 09:25 AM, Juan Quintela wrote:
> "Michael S. Tsirkin" <address@hidden> wrote:
>> This way they are easier to find using standard rules.
>>
>> Signed-off-by: Michael S. Tsirkin <address@hidden>
>
> Nack.
>
> This are _internal_ files, that shouldn't be used anywere elese.
>
> Except .... that we need them to write tests. We only have two scopes
> on qemu:
> - internal: only for the subsystem we are at in
> - pubilc: they can be used everywhere
>
> So, tests came in a strange class here, because they need internal
> implementation, but they are not in the proper directory due to the way
> we do tests.
>
> I *think* that using complete paths is the only reasonable way of doing
> this.
I hit the same issue with SD tests.
The current scheme is confuse but works fine:
tests/test-vmstate.c:30:#include "migration/qemu-file-types.h"
tests/test-vmstate.c:32:#include "../migration/qemu-file-channel.h"
Michael, what about keeping those includes internal ("only for the
subsystem we are at in") and adding complete paths in
tests/Makefile.include?
Such:
tests/test-vmstate.o: QEMU_CFLAGS += -I$(SRC_PATH)/migration
- Re: [Qemu-devel] [PATCH 22/67] ui: use local path for local headers, (continued)
- [Qemu-devel] [PATCH 25/67] arch_init: sort architectures, Michael S. Tsirkin, 2018/05/03
- [Qemu-devel] [PATCH 28/67] 9pfs: add include directory headers, Michael S. Tsirkin, 2018/05/03
- [Qemu-devel] [PATCH 29/67] fsdev: add include directory headers, Michael S. Tsirkin, 2018/05/03
- [Qemu-devel] [PATCH 30/67] audio: add include directory header, Michael S. Tsirkin, 2018/05/03
- [Qemu-devel] [PATCH 35/67] hw/usb: add include directory header, Michael S. Tsirkin, 2018/05/03
- [Qemu-devel] [PATCH 33/67] hw/net: add include directory header, Michael S. Tsirkin, 2018/05/03
- [Qemu-devel] [PATCH 32/67] ui: add include directory header, Michael S. Tsirkin, 2018/05/03
- [Qemu-devel] [PATCH 36/67] migration: add include directory headers, Michael S. Tsirkin, 2018/05/03
- [Qemu-devel] [PATCH 37/67] tcg: add include directory headers, Michael S. Tsirkin, 2018/05/03
- [Qemu-devel] [PATCH 39/67] target: replace command line flags with preprocessor, Michael S. Tsirkin, 2018/05/03
- [Qemu-devel] [PATCH 38/67] helper: replace command line flags with preprocessor, Michael S. Tsirkin, 2018/05/03
- [Qemu-devel] [PATCH 34/67] hw/ppc: add include directory headers, Michael S. Tsirkin, 2018/05/03