qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 2/2] blockjob: do not cancel timer in resume


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH v2 2/2] blockjob: do not cancel timer in resume
Date: Tue, 8 May 2018 09:28:12 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0

On 05/08/2018 08:54 AM, Stefan Hajnoczi wrote:
Currently the timer is cancelled and the block job is entered by
block_job_resume().  This behavior causes drain to run extra blockjob
iterations when the job was sleeping due to the ratelimit.

This patch leaves the job asleep when block_job_resume() is called.
Jobs can still be forcibly woken up using block_job_enter(), which is
used to cancel jobs.

After this patch drain no longer runs extra blockjob iterations.  This
is the expected behavior that qemu-iotests 185 used to rely on.  We
temporarily changed the 185 test output to make it pass for the QEMU
2.12 release but now it's time to address this issue.

Cc: QingFeng Hao <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>
---
  blockjob.c                 | 22 +++++++++++++++-------
  tests/qemu-iotests/185     |  5 +----
  tests/qemu-iotests/185.out | 12 +++++-------
  3 files changed, 21 insertions(+), 18 deletions(-)

Reviewed-by: Eric Blake <address@hidden>

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org



reply via email to

[Prev in Thread] Current Thread [Next in Thread]