Re: [Qemu-devel] [PATCH] tcg: Optionally log FPU state in TCG -d cpu logging

[Philippe Mathieu-Daudé]

On 05/10/2018 11:36 AM, Richard Henderson wrote:
> On 05/10/2018 06:00 AM, Peter Maydell wrote:
>> Usually the logging of the CPU state produced by -d cpu is sufficient
>> to diagnose problems, but sometimes you want to see the state of
>> the floating point registers as well. We don't want to enable that
>> by default as it adds a lot of extra data to the log; instead,
>> allow it to be optionally enabled via -d fpu.
>>
>> Signed-off-by: Peter Maydell <address@hidden>
>> ---
>> I've found this helpful while tracking down fp-emulation related bugs.
>>
>>  include/qemu/log.h   | 1 +
>>  accel/tcg/cpu-exec.c | 9 ++++++---
>>  util/log.c           | 2 ++
>>  3 files changed, 9 insertions(+), 3 deletions(-)
> 
> Reviewed-by: Richard Henderson <address@hidden>
> 
> I'll also note that only i386 and arm check this flag;
> something to fix for the rest...

Indeed, this would reduce mips_cpu_dump_state() output.