[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 2/9] raw: Implement copy offloading
From: |
Fam Zheng |
Subject: |
Re: [Qemu-devel] [PATCH v3 2/9] raw: Implement copy offloading |
Date: |
Fri, 11 May 2018 14:19:32 +0800 |
User-agent: |
Mutt/1.9.2 (2017-12-15) |
On Wed, 05/09 10:17, Eric Blake wrote:
> On 05/09/2018 09:58 AM, Fam Zheng wrote:
> > Just pass down to ->file.
> >
> > Signed-off-by: Fam Zheng <address@hidden>
> > Reviewed-by: Stefan Hajnoczi <address@hidden>
> > ---
> > block/raw-format.c | 20 ++++++++++++++++++++
> > 1 file changed, 20 insertions(+)
> >
> > diff --git a/block/raw-format.c b/block/raw-format.c
> > index a378547c99..febddf00c0 100644
> > --- a/block/raw-format.c
> > +++ b/block/raw-format.c
> > @@ -482,6 +482,24 @@ static int raw_probe_geometry(BlockDriverState *bs,
> > HDGeometry *geo)
> > return bdrv_probe_geometry(bs->file->bs, geo);
> > }
> > +static int coroutine_fn raw_co_copy_range_from(BlockDriverState *bs,
> > + BdrvChild *src, uint64_t
> > src_offset,
> > + BdrvChild *dst, uint64_t
> > dst_offset,
> > + uint64_t bytes,
> > BdrvRequestFlags flags)
> > +{
> > + return bdrv_co_copy_range_from(bs->file, src_offset, dst, dst_offset,
> > + bytes, flags);
>
> Bug - this fails to take into account s->offset, which occurs when opening a
> raw format protocol over a subset of the overall format protocol.
Good catch. I'll fix it in v4. Thanks.
Fam
- [Qemu-devel] [PATCH v3 0/9] qemu-img convert with copy offloading, Fam Zheng, 2018/05/09
- [Qemu-devel] [PATCH v3 1/9] block: Introduce API for copy offloading, Fam Zheng, 2018/05/09
- [Qemu-devel] [PATCH v3 2/9] raw: Implement copy offloading, Fam Zheng, 2018/05/09
- [Qemu-devel] [PATCH v3 3/9] qcow2: Implement copy offloading, Fam Zheng, 2018/05/09
- [Qemu-devel] [PATCH v3 4/9] file-posix: Implement bdrv_co_copy_range, Fam Zheng, 2018/05/09
- [Qemu-devel] [PATCH v3 5/9] iscsi: Query and save device designator when opening, Fam Zheng, 2018/05/09
- [Qemu-devel] [PATCH v3 6/9] iscsi: Create and use iscsi_co_wait_for_task, Fam Zheng, 2018/05/09