[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 14/19] target/s390x: Remove floatX_maybe_silence
From: |
David Hildenbrand |
Subject: |
Re: [Qemu-devel] [PATCH 14/19] target/s390x: Remove floatX_maybe_silence_nan from conversions |
Date: |
Fri, 11 May 2018 08:47:36 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 |
On 11.05.2018 02:43, Richard Henderson wrote:
> This is now handled properly by the generic softfloat code.
>
> Cc: Alexander Graf <address@hidden>
> Cc: David Hildenbrand <address@hidden>
> Signed-off-by: Richard Henderson <address@hidden>
> ---
> target/s390x/fpu_helper.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/target/s390x/fpu_helper.c b/target/s390x/fpu_helper.c
> index 43f8bf1c94..5c5b451b3b 100644
> --- a/target/s390x/fpu_helper.c
> +++ b/target/s390x/fpu_helper.c
> @@ -269,7 +269,7 @@ uint64_t HELPER(ldeb)(CPUS390XState *env, uint64_t f2)
> {
> float64 ret = float32_to_float64(f2, &env->fpu_status);
> handle_exceptions(env, GETPC());
> - return float64_maybe_silence_nan(ret, &env->fpu_status);
> + return ret;
> }
>
> /* convert 128-bit float to 64-bit float */
> @@ -277,7 +277,7 @@ uint64_t HELPER(ldxb)(CPUS390XState *env, uint64_t ah,
> uint64_t al)
> {
> float64 ret = float128_to_float64(make_float128(ah, al),
> &env->fpu_status);
> handle_exceptions(env, GETPC());
> - return float64_maybe_silence_nan(ret, &env->fpu_status);
> + return ret;
> }
>
> /* convert 64-bit float to 128-bit float */
> @@ -285,7 +285,7 @@ uint64_t HELPER(lxdb)(CPUS390XState *env, uint64_t f2)
> {
> float128 ret = float64_to_float128(f2, &env->fpu_status);
> handle_exceptions(env, GETPC());
> - return RET128(float128_maybe_silence_nan(ret, &env->fpu_status));
> + return RET128(ret);
> }
>
> /* convert 32-bit float to 128-bit float */
> @@ -293,7 +293,7 @@ uint64_t HELPER(lxeb)(CPUS390XState *env, uint64_t f2)
> {
> float128 ret = float32_to_float128(f2, &env->fpu_status);
> handle_exceptions(env, GETPC());
> - return RET128(float128_maybe_silence_nan(ret, &env->fpu_status));
> + return RET128(ret);
> }
>
> /* convert 64-bit float to 32-bit float */
> @@ -301,7 +301,7 @@ uint64_t HELPER(ledb)(CPUS390XState *env, uint64_t f2)
> {
> float32 ret = float64_to_float32(f2, &env->fpu_status);
> handle_exceptions(env, GETPC());
> - return float32_maybe_silence_nan(ret, &env->fpu_status);
> + return ret;
> }
>
> /* convert 128-bit float to 32-bit float */
> @@ -309,7 +309,7 @@ uint64_t HELPER(lexb)(CPUS390XState *env, uint64_t ah,
> uint64_t al)
> {
> float32 ret = float128_to_float32(make_float128(ah, al),
> &env->fpu_status);
> handle_exceptions(env, GETPC());
> - return float32_maybe_silence_nan(ret, &env->fpu_status);
> + return ret;
> }
>
> /* 32-bit FP compare */
>
Reviewed-by: David Hildenbrand <address@hidden>
--
Thanks,
David / dhildenb
- [Qemu-devel] [PATCH 09/19] target/arm: Remove floatX_maybe_silence_nan from conversions, (continued)
- [Qemu-devel] [PATCH 09/19] target/arm: Remove floatX_maybe_silence_nan from conversions, Richard Henderson, 2018/05/10
- [Qemu-devel] [PATCH 07/19] fpu/softfloat: Replace float_class_msnan with parts_silence_nan, Richard Henderson, 2018/05/10
- [Qemu-devel] [PATCH 11/19] target/m68k: Use floatX_silence_nan when we have already checked for SNaN, Richard Henderson, 2018/05/10
- [Qemu-devel] [PATCH 10/19] target/hppa: Remove floatX_maybe_silence_nan from conversions, Richard Henderson, 2018/05/10
- [Qemu-devel] [PATCH 12/19] target/mips: Remove floatX_maybe_silence_nan from conversions, Richard Henderson, 2018/05/10
- [Qemu-devel] [PATCH 13/19] target/riscv: Remove floatX_maybe_silence_nan from conversions, Richard Henderson, 2018/05/10
- [Qemu-devel] [PATCH 15/19] fpu/softfloat: Use float*_silence_nan in propagateFloat*NaN, Richard Henderson, 2018/05/10
- [Qemu-devel] [PATCH 16/19] fpu/softfloat: Remove floatX_maybe_silence_nan, Richard Henderson, 2018/05/10
- [Qemu-devel] [PATCH 14/19] target/s390x: Remove floatX_maybe_silence_nan from conversions, Richard Henderson, 2018/05/10
- Re: [Qemu-devel] [PATCH 14/19] target/s390x: Remove floatX_maybe_silence_nan from conversions,
David Hildenbrand <=
- [Qemu-devel] [PATCH 17/19] fpu/softfloat: Introduce SNAN_BIT_IS_ONE, Richard Henderson, 2018/05/10
- [Qemu-devel] [PATCH 18/19] fpu/softfloat: Pass FloatClass to pickNaN, Richard Henderson, 2018/05/10
- [Qemu-devel] [PATCH 19/19] fpu/softfloat: Pass FloatClass to pickNaNMulAdd, Richard Henderson, 2018/05/10