Re: [Qemu-devel] [PATCH 10/42] job: Add JobDriver.job_type

[Max Reitz]

On 2018-05-09 18:26, Kevin Wolf wrote:
> This moves the job_type field from BlockJobDriver to JobDriver.
> 
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
>  include/block/blockjob_int.h |  3 ---
>  include/qemu/job.h           | 11 +++++++++++
>  block/backup.c               |  2 +-
>  block/commit.c               |  2 +-
>  block/mirror.c               |  4 ++--
>  block/stream.c               |  2 +-
>  blockjob.c                   | 16 +++++++---------
>  job.c                        | 10 ++++++++++
>  8 files changed, 33 insertions(+), 17 deletions(-)
> 

[...]

> diff --git a/include/qemu/job.h b/include/qemu/job.h
> index b4b49f19e1..c87e951c8a 100644
> --- a/include/qemu/job.h
> +++ b/include/qemu/job.h

[...]

> @@ -57,4 +62,10 @@ struct JobDriver {
>   */
>  void *job_create(const char *job_id, const JobDriver *driver, Error **errp);
>  
> +/** Returns the JobType of a given Job. */
> +JobType job_type(Job *job);
> +
> +/** Returns the enum string for the JobType of a given Job. */
> +const char *job_type_str(Job *job);
> +

Is there a good reason for these not to take a const Job *?

Depending on the answer:

Reviewed-by: Max Reitz <address@hidden>

>  #endif

signature.asc
Description: OpenPGP digital signature