[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] linux-user: Assert on bad type in thunk_type_al
From: |
Laurent Vivier |
Subject: |
Re: [Qemu-devel] [PATCH] linux-user: Assert on bad type in thunk_type_align() and thunk_type_size() |
Date: |
Mon, 14 May 2018 20:23:22 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 |
Le 14/05/2018 à 19:46, Peter Maydell a écrit :
> In thunk_type_align() and thunk_type_size() we currently return
> -1 if the value at the type_ptr isn't one of the TYPE_* values
> we understand. However, this should never happen, and if it does
> then the calling code will go confusingly wrong because none
> of the callsites try to handle an error return. Switch to an
> assertion instead, so that if this does somehow happen we'll have
> a nice clear backtrace of what happened rather than a weird crash
> or misbehaviour.
>
> This also silences various Coverity complaints about not handling
> the negative return value (CID 1005735, 1005736, 1005738, 1390582).
>
> Signed-off-by: Peter Maydell <address@hidden>
> ---
> include/exec/user/thunk.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Laurent Vivier <address@hidden>