|
From: | Eric Blake |
Subject: | Re: [Qemu-devel] [PATCH 07/42] blockjob: Remove block_job_pause/resume_all() |
Date: | Mon, 14 May 2018 14:45:24 -0500 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 |
On 05/11/2018 05:30 PM, Max Reitz wrote:
On 2018-05-09 18:26, Kevin Wolf wrote:Commit 81193349 removed the only use of block_job_pause/resume_all(), which was in bdrv_drain_all(). The functions are now unused and can be removed.I have a strange liking for all-digit commit hash prefixes.
Especially when the first digit is 0, but then the rest includes an 8 or 9. (in the past, I've actually had a script transiently break when parsing commit ids, and it took me quite a while to figure out why the problem disappeared after I rebased, until I finally realized that it was because the script was choking on an attempt to parse an invalid octal number, only when I got lucky enough to land on a problematic commit id)
-- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
[Prev in Thread] | Current Thread | [Next in Thread] |